search

Pasukaru / DSP-Mods

MIT License
5 stars 4 forks source link

Crash with 0.9.27.14533 #19

Open Chemie99 opened 2 years ago

Chemie99 commented 2 years ago

Place ILS or PLS. Crash image

The change to PLS/ILS/distributor where they have an auto-replenish option is likely what broke it but still nice to be able to config with this mod (number added) and all the other settings too.

Is this still supported by author?

Violist4Life commented 2 years ago

I also get errors when trying to load a game: Screenshot 2022-09-30 130851

Pasukaru commented 2 years ago

Mod is not compatible with newer DSP versions, as they have changed some functions that the mod uses.

There's already a PR that seems to fix this: https://github.com/Pasukaru/DSP-Mods/pull/18

I currently don't have time to test this and I'm not at home over the weekend. So it'll have to wait until next weekend.

In the mean time, you could try to compile the PR yourself and use that until the mod is updated.

soarqin commented 2 years ago

I have uploaded precompiled binary based on my fixes here: https://github.com/soarqin/DSP_AutoStationConfig/releases/tag/1.4.0-fix

Chemie99 commented 2 years ago

I have uploaded precompiled binary based on my fixes here: https://github.com/soarqin/DSP_AutoStationConfig/releases/tag/1.4.0-fix

Thanks will test it out today. Edit: Still crashed image

lonix commented 2 years ago

@soarqin that fix worked for me.

Chemie99 commented 2 years ago

@soarqin that fix worked for me.

Weird. I disabled all mods and it still crashes

soarqin commented 2 years ago

@soarqin that fix worked for me.

Weird. I disabled all mods and it still crashes

Sorry for late to reply, this should be caused by a null pointer check issue in my old precompiled binary, re-download updated DLL and load from an earlier auto-save. This was my fault, my apologize!

Chemie99 commented 1 year ago

@soarqin that fix worked for me.

Weird. I disabled all mods and it still crashes

Sorry for late to reply, this should be caused by a null pointer check issue in my old precompiled binary, re-download updated DLL and load from an earlier auto-save. This was my fault, my apologize!

No worries. Any chance of you providing a new precompiled binary; happy to beta test for you

soarqin commented 1 year ago

No worries. Any chance of you providing a new precompiled binary; happy to beta test for you

already updated, but cannot fix broken saves. just redownload from the same link.

Chemie99 commented 1 year ago

No worries. Any chance of you providing a new precompiled binary; happy to beta test for you

already updated, but cannot fix broken saves. just redownload from the same link.

What is meant by "broken saves"....this mod does not affect saves? Anyway, I download the above link (from Oct. 3 which which has a Oct. 4 file date), started a new sandbox game, and still get error image

soarqin commented 1 year ago

this is strange, I can confirm that the bug is fixed coz I am using it all the way, do you use any other mods that affects PLS/ILS logic? I have updated binary to fix a small issue in original link, you can try this new one. If it still does not working, there might be some mods conflict.

Chemie99 commented 1 year ago

this is strange, I can confirm that the bug is fixed coz I am using it all the way, do you use any other mods that affects PLS/ILS logic? I have updated binary to fix a small issue in original link, you can try this new one. If it still does not working, there might be some mods conflict.

I loaded with all mods disabled (except this one). Fresh sandbox game. Do I have the right version? Your link above is still a file dated at Oct. 4....

soarqin commented 1 year ago

this is strange, I can confirm that the bug is fixed coz I am using it all the way, do you use any other mods that affects PLS/ILS logic? I have updated binary to fix a small issue in original link, you can try this new one. If it still does not working, there might be some mods conflict.

I loaded with all mods disabled (except this one). Fresh sandbox game. Do I have the right version? Your link above is still a file dated at Oct. 4....

I have uploaded a file named AutoStationConfig-20221113.zip there to show compilation date, pls check again.

starfi5h commented 1 year ago

@Chemie99 Have you removed/replaced the old AutoStationConfig.dll? Because if there are two plugins with the same guide and version, one of them may not be loaded.

@soarqin Maybe bump the fixed plugin version to 1.4.1 in the binary file to avoid the above situation?

Chemie99 commented 1 year ago

@Chemie99 Have you removed/replaced the old AutoStationConfig.dll? Because if there are two plugins with the same guide and version, one of them may not be loaded.

Thanks @starfi5h and @soarqin Yes, I downloaded the file and overwrote the existing dll in the original folder.
I tried again today with this approach:

  1. Delete the autostationconfig mod folder from rdmodman mod directory
  2. Delete the rdmodman config file for this mod
  3. Install "old" 1.4.0 from site shelf.
  4. download and install the new dll by overwriting the existing dll in the mod folder
  5. Run once to create config file. Exit and restart
  6. Run program with all mods disabled and new game sandbox mod
  7. Still get same error message as above.
starfi5h commented 1 year ago

Try go to Settings -> Debugging -> click Clean mod cache. Or you can try to install ModFixerOne mod, which fixs the error by patching AutoStationConfig mod.

If those don't work, you can post the log file BepInEx\LogOutput.log here so we can try to find the issue.

Chemie99 commented 1 year ago

Try go to Settings -> Debugging -> click Clean mod cache. Or you can try to install ModFixerOne mod, which fixs the error by patching AutoStationConfig mod.

If those don't work, you can post the log file BepInEx\LogOutput.log here so we can try to find the issue.

I think it was a modman issue. adding to above steps

  1. Uninstall autostationconfig again
  2. Reinstall from shelf (noticed the same patched dll in the folder so uninstall did not delete the directory apparently)
  3. Install ModFixerOne
  4. Run game and exit
  5. Open modman config editor and notice now the newer setting available (like miners); this was not the case in step 5 above
  6. Run game and works
  7. Disable modfixerone; still no crashes

So something was happening with the cache for modman as I know the config editor did not show the miner when I installed the patched .dll. (modman did not see it as new version since in original folder). I do not think modfixerone was doing anything but maybe loading it cleared some cache or something. After installing it, modman seemed to grab the newer dll for autostationconfig (even though only the newer one was in the directory. I do not know how the caching works but I suspect it was cached the older version and did not refresh it until I added modfixerone,

Anyway, thanks all for the help troubleshooting.