PatGet / XamarinPlayCoreUpdater

Initial
MIT License
44 stars 13 forks source link

Update to 1.10.2 version #19

Open EmilAlipiev opened 3 years ago

EmilAlipiev commented 3 years ago

Library is 2 release behind and google had some important fixes . Can we get that updated? I can also do and send a pr but i cannot find the latest .aar file. Where did you download it from?

https://developer.android.com/reference/com/google/android/play/core/release-notes

saamerm commented 3 years ago

@EmilAlipiev good catch. https://developer.android.com/guide/playcore#java-kotlin I can't find the latest version either. The two latest releases seem to be super recent

PatGet commented 3 years ago

Best place is google's maven repo. You can find the aar here https://maven.google.com/web/m_index.html?q=Core#com.google.android.play:core:1.10.2

saamerm commented 3 years ago

@EmilAlipiev did you still want to test and submit the PR, or should I do it?

EmilAlipiev commented 3 years ago

@EmilAlipiev did you still want to test and submit the PR, or should I do it?

I havent been able to find a free time lately. If you can, it will be lovely. Thanks

saamerm commented 3 years ago

@PatGet I don't know if I have the permissions to upload the new nuget for 1.10.2 Any way I can help?

PatGet commented 3 years ago

I uploaded the NuGet as rc1. https://www.nuget.org/packages/PlayCore/1.10.2-rc1

PatGet commented 3 years ago

I needed to Update to rc2 as i originally compiled with VS2022 Preview. This broke my Test App Builds in AppCenter due to newer Xamarin.Android Version which is not yet available on AppCenter.

DaviBittencourt commented 3 years ago

Hi, I'm having problems updating apps, the download and installation process happens, but the app doesn't update, everything remains the same. What should I do ? I'm using the example code

PatGet commented 3 years ago

@saamerm The rc2 Package worked just fine for me, did you do some tests? I would create an release version if you give me green light.

@DaviBittencourt Anything in the ADB Logs? Are you using Google App Signing and testing with your own certificate?

saamerm commented 2 years ago

@PatGet this version looks good, as verified here: https://github.com/jamesmontemagno/StoreReviewPlugin/issues/34

lgtm