Fix setting .m to 0 not setting layer and exponent

Patashu / break_eternity.js

A Javascript numerical library to represent numbers as large as 10^^1e308 and as small as 10^-10^^1e308. Sequel to break_infinity.js, designed for incremental games.

MIT License

122 stars 46 forks source link

Fix setting .m to 0 not setting layer and exponent #84

Closed mcpower closed 2 years ago

mcpower commented 2 years ago

The two expressions in the if block were no-ops.

To prevent this from happening in the future, this PR also enables eslint's no-unused-expression lint.

This PR conflicts with #83 as they both change .eslintrc.js. Choose one to merge first and I'll rebase the other one on top of HEAD (or you can resolve the merge conflicts yourself).

Patashu commented 2 years ago

I assume it doens't matter what order you write stuff in eslintrc.js, let me know if that's a wrong assumption

mcpower commented 2 years ago

Yep, doesn't matter what order. Thanks for merging this in!