search

Patbox / StyledChat

Style your chat as you want! (Server side, Fabric)
GNU Lesser General Public License v3.0
70 stars 15 forks source link

Incompatible with the Better Fabric Console #24

Closed nikijaz closed 2 years ago

nikijaz commented 2 years ago

Better Fabric Console Logs: https://mclo.gs/Is8bvrE

nikijaz commented 2 years ago

Styled Chat: v1.3.2 Better Fabric Console: v1.0.5

Patbox commented 2 years ago

Uh weird. This should never happen (it fails to register custom chat message type). Does it only happen with Better Fabric Logs? If so, report that to them

Patbox commented 2 years ago

Also related SC code: https://github.com/Patbox/StyledChat/blob/1.19/src/main/java/eu/pb4/styledchat/StyledChatMod.java#L35

dadoirie commented 2 years ago

can't confirm that as I've got better fabric console and styled chat installed and minecraft does load - maybe another mod does conflict with styledchat - try loading only the bare minimum - like better fabric and styled chat and their dependencies and see if that crash still happens

nikijaz commented 2 years ago

Checked with only Styled Chat, Better Fabric Console and Fabric API - the problem remains. Also tried to reinstall the mods, maybe the files are corrupted, but it did not help.

I downloaded Styled Chat from here and Better Fabric Console from here.

nikijaz commented 2 years ago

This version works great, but starting from this server crashes. So, i suppose that the problem is in this commit.

cadenkriese commented 2 years ago

I don't think this is specific to Better Fabric Console, or even Fabric. I'm getting a similar error with Quilt https://mclo.gs/NnFDYvh

nikijaz commented 2 years ago

weird

cadenkriese commented 2 years ago

I've done more fiddling and found the conflicting mod on my end is jpenilla/ModsCommand, coincidentally by the same author. I might be able to tackle this issue and submit a PR, @Patbox what is the styled_chat:generic_hack registry used for? Also why is it considered hacky?

Patbox commented 2 years ago

It's used for formatting, as I wanted to keep valid in case of player/signature, while allowing for more formatting than new Mojang's suggested system (which didn't work 100% like I wanted it anyway), so Styled Chat technically display everything in player name and ignores real contents of message

Patbox commented 2 years ago

Maybe it's https://github.com/KyoriPowered/adventure-platform-fabric, as it is common dependency between both

Patbox commented 2 years ago

Should be fixed on latest

jpenilla commented 2 years ago

The actual conflict is with confabricate, it isn't properly updated for 1.19 yet and I've removed the dependency from my mods.