search

Patbox / TaterCart

A server side (works on singleplayer too) Minecart mod for Fabric
GNU Lesser General Public License v3.0
19 stars 2 forks source link

AbstractMinecartEntity Mixin Crash #11

Open xanthian opened 2 years ago

xanthian commented 2 years ago

With my mod that adds new rails, mixin to enable carts to function on them. Unsure if issue your side or mine

https://github.com/xanthian/variant_sticks_and_stuff/issues/6

Currently updating to 1.19 but not changed anything in the mixin https://github.com/xanthian/variant_sticks_and_stuff/blob/1.19/src/main/java/net/xanthian/vsas/mixin/AbstractMinecartEntityMixin.java

Patbox commented 2 years ago

My mixin is more generic, so ideally you should mark yours as optional

https://github.com/Patbox/TaterCart/blob/1.19/src/main/java/eu/pb4/tatercart/mixin/minecart/movement/AbstractMinecartEntityMixin.java#L121

xanthian commented 2 years ago

How? :P

xanthian commented 2 years ago

Cant make it optional as from what I can tell your mixin doesnt provide the appropriate functionality required for the rails types to function. Also, mod doesnt work on 1.19.2 so unable to carry out any testing.