Closed solonovamax closed 2 years ago
Possibly related, since they both appeared after updating to 1.19.2: #25
@Patbox I've identified the issue as being the lines
for (var sibling : input.getSiblings()) {
baseText.append(cloneText(sibling));
}
in GeneralUtils.
There are two fixes for this:
baseText.getSiblings().clear();
in front of the for loop, to clear the siblings.What's happening is that Text#copy
already copies the siblings, according to Text.class
:
default MutableText copy() {
return new MutableText(this.getContent(), new ArrayList(this.getSiblings()), this.getStyle());
}
This causes them to be duplicated.
Would you like me to PR these changes?
I have that fixed locally, just working on some other changes/improvements
Ah, alright sick.
Would you be able to publish a new release with these changes? Because, it's kinda annoying me on my server lol
no pressure though, I can always use my own build
oh yeah, changes aren't pushed so I probably shouldn't close lol
Will keep open until released. Through yeah soon (just need to test more changes/features I made)
Currently, the placeholder api is returning the incorrect name with
%player:displayname_visual%
.Example:
It should be displaying
However, for some reason it is repeating the name twice (or more sometimes):
You can compound the effect when nesting
%player:displayname_visual%
.Using the styled chat mod, if you set
displayName
to something that includes%player:displayname_visual%
, then you may get an output similar to the following:The mods
Here is a shortened version of my styled chat config to include all relevant info: