Patbox / UniversalGraves

Grave mod for Fabric!
GNU Lesser General Public License v3.0
55 stars 25 forks source link

After a crash, all graves were removed #155

Closed BigCod3 closed 5 months ago

BigCod3 commented 5 months ago

Recently while running back to my grave, the game quickly shutdown with the error: Cannot encode empty ItemStack. After logging back in, my compass to my grave was missing, and the graves themselves were also gone.

Full error below:

Time: 2024-06-16 09:59:10 Description: Exception in server tick loop

java.lang.IllegalStateException: Cannot encode empty ItemStack at net.minecraft.class_1799.method_57358(class_1799.java:401) at eu.pb4.graves.grave.PositionedItemStack.toNbt(PositionedItemStack.java:28) at eu.pb4.graves.grave.Grave.writeNbt(Grave.java:169) at eu.pb4.graves.grave.GraveManager.method_75(GraveManager.java:73) at net.minecraft.class_18.method_17919(class_18.java:42) at net.minecraft.class_26.method_32384(class_26.java:127) at java.base/java.util.HashMap.forEach(HashMap.java:1429) at net.minecraft.class_26.method_125(class_26.java:125) at net.minecraft.class_3218.method_14188(class_3218.java:833) at net.minecraft.class_3218.method_14176(class_3218.java:815) at net.minecraft.server.MinecraftServer.method_3723(MinecraftServer.java:556) at net.minecraft.server.MinecraftServer.method_39218(MinecraftServer.java:580) at net.minecraft.class_1132.method_39218(class_1132.java:318) at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:924) at net.minecraft.class_1132.method_3748(class_1132.java:114) at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:697) at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:281) at java.base/java.lang.Thread.run(Thread.java:1583)

BigCod3 commented 5 months ago

How is this completed? I just got this same crash again with 'Cannot encode empty ItemStack'. Would be nice if you provided any info around an issue before closing it.

Patbox commented 5 months ago

Logs and version?

BigCod3 commented 5 months ago

Version is 1.21, I'm not sure how much more logs I could provide. The crash report doesn't give any more info, but here it is. Thank you for looking into this, I love the mod but am worried to continue using it given the chance that my grave could completely despawn. crash-2024-06-20_11.48.03-server.txt

Patbox commented 5 months ago

You run outdated version of universal graves, latest is 3.4.1+1.21 and you run on 3.4.0+1.21

BigCod3 commented 5 months ago

Ah so there was an update released on the day I posted this, could have been worth mentioning when you closed the issue. I'll make sure to update. Take care.

Patbox commented 5 months ago

Yeah I closed it as new version got released