Patbox / UniversalShops

Universal trade shop mod for your Minecraft server!
GNU Lesser General Public License v3.0
12 stars 13 forks source link

Duping possible when withdrawing items from currency storage #15

Closed orxngc closed 1 year ago

orxngc commented 1 year ago

I love this mod, but I don't want a dupe possible on my server! Basically what happens is if you withdraw say 5 diamond blocks from the currency storage then quickly store it in a chest, you can again withdraw the 5 diamond blocks. idk what other info to put here EDIT: i should mention that this is on a 1.19.2 fabric server

Patbox commented 1 year ago

Hey, could you send a video showcasing it?

orxngc commented 1 year ago

Sure, I'll do it as soon as I can :D

Patbox commented 1 year ago

Also does it happen in survival?

orxngc commented 1 year ago

It does happen in survival. I cannot provide footage right now as it is quite difficult to replicate and both people including myself who did the dupe forgot how to... I'll figure it out as soon as I can sorry.

Patbox commented 1 year ago

Closing for now. It's highly likely the bug was purely visual (client/server desync) so it wasn't actually duping anything (and if you were on creative, client likes to force-set slots a lot so it could make these items real, but thats creative only thing)