Properties rework, book updates and added sign gui

Patbox / sgui

Library for creating custom, server side guis on Fabric

GNU Lesser General Public License v3.0

91 stars 17 forks source link

Properties rework, book updates and added sign gui #4

Closed aws404 closed 3 years ago

aws404 commented 3 years ago

This PR includes:

Moving properties to an enum so you don't have to look up the property value each time.
- Also moved the property method to the interface rather than SimpleGui as properties are universal for ScreenHandlers not just Containers
Separating the classes in virtual into separate sub-packages.
Reworking some of the BookGUI
- Allow for getting and setting the current page
- Allows for an easy action for the 'Take Book' button
Some other cleanups here and there

Patbox commented 3 years ago

Look great! Only thing I'm not sure is, if it should still target 1.16 (as initial port to 1.17 was made already). Hovewer if you plan to use these features on 1.16, I will merge it as is and port it myself.

aws404 commented 3 years ago

Love for it to be merged into 1.16 but I'm happy to port it to 1.17 too if that would help.

Patbox commented 3 years ago

Merging then :)