PatchworkBoy / homebridge-edomoticz

Domoticz Homebridge-Plugin
Other
118 stars 44 forks source link

RGB subtype for SwitchTypeVal 7 #161

Closed morilm closed 4 years ago

morilm commented 6 years ago

Hi there...

After the implementation of the RBG switch in domozticz, should it be possible to add the RGB subtype(s) into homebrigde?

See bellow example of Json query with the "color" information on a RGB switch. Device is seem at homebrigde as a "dimmer" only device (no color). On/off and %bright works ok.

So it seems Homekit have different switch type(s) for dimmers&on/off vs the one to pickup colors.

Thanks Miguel

{ "result" : [ { "Color" : "{\"b\":255,\"cw\":0,\"g\":3,\"m\":3,\"r\":176,\"t\":0,\"ww\":0}", "SubType" : "RGB", "SwitchType" : "Dimmer", "SwitchTypeVal" : 7, "Timers" : "false", "Type" : "Color Switch", "TypeImg" : "dimmer", "idx" : "2476" } ], "status" : "OK", "title" : "Devices" }

PatchworkBoy commented 6 years ago

Homebridge-edomoticz is programmed to support subtype RGBW and RGBWW at the moment.

Full code would have to be written to support, and I don’t have any subtype RGB devices with which to test.

morilm commented 6 years ago

PatchworkBoy... the issue can be seen with virtual devices too.

If you create a RGB/RGBW/RGBWW switch on domoticz (updated version) it's been seen as dimmer only (no color choice) device on homekit.

regards Miguel

morilm commented 6 years ago

Sorry.. last minute correction. Issue is only happening with RGB subtype.. RGBW/WW seems to be fine,,

jacobhallgren commented 5 years ago

+1 on this it would be nice

EdddieN commented 5 years ago

What about Type: colour siwtch, subtype: RGBWWZ, I see them only as dimmers, no colour

jacobhallgren commented 5 years ago

Any updates on this :)?

jacobhallgren commented 5 years ago

Fixed it

Line 1446 in lib/domoticz_accessory.js add this: if (this.subType == "RGBW" || this.subType == "RGBWW" || this.subType == "RGBWWZ"

PatchworkBoy commented 4 years ago

Fixed in https://github.com/PatchworkBoy/homebridge-edomoticz/commit/42ff35a09e5ffe95432f604ca9e1a543c2b00454