search

PatchworkBoy / homebridge-edomoticz

Domoticz Homebridge-Plugin
Other
118 stars 44 forks source link

Domoticz Settings change to Fahrenheit confuses homebridge #172

Open gknops opened 5 years ago

gknops commented 5 years ago

When I change the Settings/Temperature to display in Fahrenheit, Homekit (via home bridge) interprets the Fahrenheit as if it were celsius. Changing the setting back to Celsius and Homekit shows the temperature correct.

Example:

Settings: Celsius (correct) Domoticz: 0ºC, Homekit 32F

Settings: Fahrenheit (wrong) Domoticz: 32F, Homekit: 90F (32ºC)

Domoticz folks say: When homebridge is using the json 'getconfig' it will receive the scaling

And homebridge folks say: homebridge/HomeKit uses Celsius internally and the plugin needs to normalize the data

This sounds like #106 which was fixed last year, but I installed the plugin July 2018 using "npm install -g homebridge-edomoticz", shouldn't that have picked up the fix for #106?

https://github.com/PatchworkBoy/homebridge-edomoticz/issues/106

PatchworkBoy commented 5 years ago

There was no fix committed / pull request despatched for #106... I suggested corrections to deal with a single device but as stated there, rest of source would need inspecting for anywhere else that may be impacted.