search

PatchworkBoy / homebridge-edomoticz

Domoticz Homebridge-Plugin
Other
118 stars 43 forks source link

Lock support #36

Closed jonferreira closed 8 years ago

jonferreira commented 8 years ago

Fantastic work so far, congrats!

Any chance we can get proper "lock" support?

"SubType" : "Switch", "SwitchType" : "Door Lock", "SwitchTypeVal" : 11,

This was I could tell Siri to "lock/unlock Garage Gate" instead of "Turn On/Off Garage Gate" if that makes sense

PatchworkBoy commented 8 years ago

Hmmm. I should look to sanitising the string for text services then... rather it handled more gracefully!

jonferreira commented 8 years ago

oddly enough it seems to be working on 99% times

Fri, 26 Aug 2016 08:09:28 GMT Accessory [Homebridge] Getting value for Characteristic "Location"
Fri, 26 Aug 2016 08:09:28 GMT Accessory [Homebridge] Got Characteristic "Location" value: <iframe width="365" height="300" frameborder="0" style="border:0" src="https://www.google.com/maps/embed/v1/place?key=AIzaSyDJEFKMCqoOUnG4vf1KzI6W0ZNWFV1D0rk&maptype=satellite&q=xxxx" allowfullscreen></iframe>
rswilem commented 8 years ago

I think occasionally your "Text" returns an empty string / nothing. This is when homebridge crashes. Seconds after that it returns its right value.

Anyhow, fixed by adding the 'undefined' check!