Closed rikka0w0 closed 4 years ago
The logic here is somewhat tricky, but looks sound.
If #127 ends up merged before this, can you include the implementation of ForgeHooks.canHarvestBlock?
Yes of course, and also there are other things that I'm going to add to ForgeHooks and ForgeHooksClient. In all of my PRs, the event dispatch is handled by individual classes, and ForgeHooks is only supposed to be used for accepting Forge mod calls.
Merge conflicts!
getExpDrops will be always called for all blocks, the exp orb drop behavior follows this rule:
Fabric mods does not have a method to get the amount of experience dropped from another block. If a Forge mod calls getExpDrop on a Fabric mod block, it will always get 0. This will be changed once Fabric has something equivalent.
getHarvestTool and getHarvestLevel are stubs, I will impl more tooltype stuff in another pr.