PatchworkMC / patchwork-api

An attempt to reimplement the Minecraft Forge API on Fabric
GNU Lesser General Public License v2.1
282 stars 48 forks source link

Clean up stacktrace for unimplemented class / method / field errors. #138

Closed cittyinthecloud closed 4 years ago

cittyinthecloud commented 4 years ago

This keeps stack traces resulting from unimplemented classes and members from being full of confusing Mixin and class loading errors.

rikka0w0 commented 4 years ago

I would like to suggest that we should include a link for the users to submit their issue, for example, the github issue page.

florensie commented 4 years ago

Maybe check if the class/method/field is actually in the forge package?

kitlith commented 4 years ago

Forge adds methods and fields to vanilla classes, too, @florensie

florensie commented 4 years ago

@kitlith Fair but what if it's something else like a class missing in a dependency mod. I guess it might be too much effort to check every package forge touches.

kitlith commented 4 years ago

@florensie we could limit to net.minecraftforge and net.minecraft then? That's still not perfect if a mod adds a class under net.minecraft to access package private things, but it's something.

TheGlitch76 commented 4 years ago

We don't let mods add things under the net.minecraft package, yet