search

PatchworkMC / patchwork-api

An attempt to reimplement the Minecraft Forge API on Fabric
GNU Lesser General Public License v2.1
283 stars 48 forks source link

Completely stub all classes in god-classes #203

Closed kitlith closed 4 years ago

kitlith commented 4 years ago

NOTE: current commit only stubs ForgeHooksClient, just to get an idea of what this would look like.

Alternative to #202, basically a dead simple approach to reducing conflicts by adding more context.

Somewhat tedious to setup, but there's no underlying complexity that could bite us in the ass later.

Also introduces an annotation to mark stubbed items so that we can detect them in other tools (like patcher?)

cittyinthecloud commented 4 years ago

AFAICT All functionality that these classes had before is still present. Maybe add a comment at the top explaining not to try to use them in other modules, part of the appeal of codegen for me was that it made it pretty clear that the classes weren't meant for us.

kitlith commented 4 years ago

huh, i thought they all ready had comments at the top. at least a couple of them do. I'll add the comments.

I'm still open to switching back to codegen if everyone else prefers codegen, but my personal scales have been tipped away from it and the other people I've asked have been non-committal, so I just. made a decision.