search

PatchworkMC / patchwork-api

An attempt to reimplement the Minecraft Forge API on Fabric
GNU Lesser General Public License v2.1
282 stars 48 forks source link

Hand Render Events #214

Closed stairman06 closed 3 years ago

stairman06 commented 3 years ago

RenderHandEvent and RenderSpecificHandEvent. Not sure if the @ModifyConstant for the if statement is the best way, but it works.

kitlith commented 3 years ago

The @ModifyConstant is fine, especially since you documented what is going on with it. Sometimes, the cleanest thing we can do is something like that in these cases.

I'd just double check that there are no other instances of '0' in the method, so that unintentional changes are not made.

stairman06 commented 3 years ago

Thanks. I've double checked and there were other 0s in the method, so I've added an ordinal to the Constant.