search

PatchworkMC / patchwork-api

An attempt to reimplement the Minecraft Forge API on Fabric
GNU Lesser General Public License v2.1
282 stars 48 forks source link

Pehkui conflicts with patchwork-api #232

Open BenCat07 opened 3 years ago

BenCat07 commented 3 years ago

the Pehkui library conflicts with patchwork api due to both of them trying to inject into the same class with the same priority.

https://paste.ee/p/CUoR1

BenCat07 commented 3 years ago

This seems strange, as from what i see patchwork-api actually uses priority 1100, not 1000. But it clamps to 1000 anyways?

CORRECTION: it used to use 1100, but that was changed in some sort of rework/rewrite of the code.

cittyinthecloud commented 3 years ago

For sanity, can you retest without Optifine? I doubt it's the bug but I don't trust it.

BenCat07 commented 3 years ago

Ohhhh, right. I'll do so.

BenCat07 commented 3 years ago

Confirmed to be optifine causing problems, not pehkui

EDIT: false, just my api was broke

GamingInfinite commented 3 years ago

I'd like to say that this is still a problem, post getting my API to work.