search

PatchworkMC / patchwork-patcher

Patches Forge mod jars, allowing them to be loaded by Fabric
GNU Lesser General Public License v3.0
315 stars 33 forks source link

yeet gson #75

Open sylv256 opened 3 years ago

sylv256 commented 3 years ago

gson bad jsoniter go brrrr

ramidzkh commented 3 years ago

What are the benefits? Patching is a one time relatively-fast process, and GSON is known to be reliable

kitlith commented 3 years ago

for some reason i was interpreting this as "replace gson w/ jsoniter in minecraft" which, in retrospect, makes no sense.

jsoniter's primary benefit over gson appears to be speed, so, I guess it depends on how much time is spent dealing with json in patcher. I'd guess the majority of the time is spent visiting stuff for patching though? (i don't know)

sylv256 commented 3 years ago

fabric did it, so why not us?

ramidzkh commented 3 years ago

Because fabric-loader has a good reason to - to not mess with Minecraft's dependencies. Copying someone else for no good reason is usually a bad idea