soc-pe-bot
commented
5 months ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Contacts with different names but same email and phone number are allowed in the app
Contacts with different names but same email and phone number are allowed in the app which does not make sense because an email and a phone number can uniquely identify a person.
Steps to reproduce:
command to enter: add John Doe -e johndoe@example.com -p 87654321 -t johndoe -s Leadership -s C++
add John Doe123 -e johndoe@example.com -p 87654321 -t johndoe -s Leadership -s C++
[original: nus-cs2103-AY2324S2/pe-interim#5315] [original labels: severity.Medium type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Thank you for your suggestion. We agree that phone numbers and emails of courseMates should be unique in most cases, thus duplicate detection in phone numbers and emails will be useful for careless users.
However, since these types of user mistakes are uncommon (typos are unlikely to cause the email / phone number to collide with another courseMate), we're downgrading the severity of the bug to "Low". This also requires extra effort for our team to implement and considering this is not a high priority task, we will mark this bug as not in scope.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: [replace this with your reason] Thanks for your response. However, while I agree that such occurrences may not be frequent, ensuring data integrity and providing a smooth user experience are paramount. Maintaining consistency and accuracy within the app is important, as it may cause some potential issues that can affect user experience. For example, when copying and pasting multiple people into the system, the user may inadvertently reuse a phone number due to human error. Without notice from the system, the user may never realize their mistake. This could lead to a failure of user experience in the future.
## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** [replace this with your reason] As the app is used to group individual students by module, and individuals can belong to multiple groups. Consistent and accurate phone numbers are important and required to avoid any kind of human error when contacting them. Furthermore, typing duplicate phone numbers often occurs when adding multiple people. Therefore, its severity is **Medium**.
Description: MatchMate is allowing user to add the person with same phone number.
To reproduce: Add the person with the same phone number. For example:
add Tester A -e johndoe@example.com -p 87654321 -t johndoe -s Leadership -s C++add Tester B -e johndoe@example.com -p 87654321 -t johndoe -s Leadership -s C++Expected behaviour The app shows an error message that the duplicated phone number cannot be entered, or the phone number is already recorded in the system.