the purpose of this commit is to breakup Database.runTests into small…

[bethanne-card]

…er pieces

[jbutler-air]

A few questions/recommendations for your review @bethanne-card :

• Harmony of Test group methods - assuming StandardTests applies to all tables, and other test groups apply to subsets of those tables (disregard if this is an incorrect assumption):
  • If the test groups are meant to be run together, we can remove some duplicated functions from the more limited-scope test group:
    • load_nulls and test_blank_count are included in both StandardTests and DisambiguationTests, so could be removed from DisambiguationTests
• Generalizability
  • In order for StandardTests to be applicable to views like those used in the export DBs, some tests should be moved out of StandardTests and into a separate test group that is specific to tables (another test group for Views may also be useful, but that can be developed later)
    • e.g. test_null_version_indicator will not apply to the export views
• Redundancy
  • Within runStandardTests(), test_related_floating_entities() is run twice(L577 and L581) with the only difference being where_vi = True/False. If I understand correctly that the False case contains the True case, can we remove the True case?
  • MergeTestQuarterly and MergeTestWeekly now appear to be identical classes; can these be combined, or even both retired, since neither looks like it adds any functionality or data over the base DatabaseTester Class?

[bethanne-card]

Thanks so much for your detailed feedback Jack!

• For the generalizability piece - what I wanted is for the functions to be generalizable - meaning that testGroups can be made dynamically with different groups of functions. I think it makes sense to make a specific TestGroup for Views