search

Path-Check / gaen-mobile

The mobile application supporting the GAEN Exposure Notifications protocol.
MIT License
42 stars 36 forks source link

GAEN-781 - URL Error Message #919

Closed RJ-Hamilton closed 3 years ago

RJ-Hamilton commented 3 years ago

Why:

As a user was attempting to check for new exposures, the app was showing to the user that the call succeeded when in fact the app was silently failing.

This commit:

This PR was used to implement a way for us to wait for the work being done in the background to succeed/fail before showing any kind of result. To do this, we had to add RXJava to the project. This enabled us to wait for the ListenableFuture to finish doing its work in the background before we continued with our work on the main thread.

Added ProvideDiagnosisKeyService to imitate the work that was being done before using ListenableFuture. The purpose of this was to give us additional options to manage threads easier and give us additional callback functionality.

How to test:

  1. Configure an invalid DOWNLOAD_BASE_URL or DOWNLOAD_PATH
  2. Build Android App and click "Check For Exposures"

Linked issues:

GAEN-781

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.