Path Check BT crashes when executed

Path-Check / safeplaces-dct-app

COVID Safe Paths (based on Private Kit) is an open and privacy preserving system to use personal information to battle COVID

https://covidsafepaths.org

MIT License

467 stars 286 forks source link

Path Check BT crashes when executed #1221

Open crayne opened 4 years ago

crayne commented 4 years ago

Issue type

Environment

Version

Release build version: 1.22.4
Affected Devices

Brand	Model	OS
<!--	Samsung	Galaxy S10	10.0	-->

Samsung Galaxy S8 emulator Samsung Galaxy S9 device

Affected Languages

Steps to reproduce

yarn run-android-bt

Expected Behavior

Normal onboarding

When I click Stop Logging I am taken to the Import screen. Expect to go back to the Welcome greeting.

johnschoeman commented 4 years ago

Looks like an issue with react-native-config, can you confirm you have a local .env.bt file with TRACING_STRATEGY=bt ?

crayne commented 4 years ago

Yes, I can. A quick fix would be to set Config.TRACING_STRATEGY to bt if it is undefined. Would that be unacceptably ugly?

johnschoeman commented 3 years ago

Yes, I can. A quick fix would be to set Config.TRACING_STRATEGY to bt if it is undefined. Would that be unacceptably ugly?

This is probably not the way we want to go here. Do you have a local .env.bt file with TRACING_STRATEGY=bt ? and can you confirm if react-native-config is working properly for you? something like

import Config from 'react-native-config'
console.log(Config)

should be sufficient.

crayne commented 3 years ago

I do have a local .env.bt file with TRACING_STRATEGY=bt. The result of

import Config from 'react-native-config'
console.log("Config.TRACING_STRATEGY is " + Config.TRACING_STRATEGY);

is LOG Config.TRACING_STRATEGY is undefined