Fixes/saf 791 - Githubissues

Path-Check / safeplaces-dct-app

COVID Safe Paths (based on Private Kit) is an open and privacy preserving system to use personal information to battle COVID

https://covidsafepaths.org

MIT License

465 stars 285 forks source link

Fixes/saf 791 #1333

Closed Sameerlaul closed 4 years ago

Sameerlaul commented 4 years ago

Description:

This PR is regarding SAF-791

made changes in styles to align green tick in center in "Health Departments" tab. Also this problem was seen in while selecting HA before "Enter verification code" screen

Linked issues:

SAF-791

Screenshots:

How to test:

JacobJaffe commented 4 years ago

Hi @Sameerlaul , thanks for the PR. Looks like you need to run prettier over these changes.

I'd recommend avoiding using percentage based approaches for fixing these flex issues, as that won't be very composable within other container contexts. I've included a fix for this here: https://github.com/Path-Check/covid-safe-paths/pull/1335/files#diff-9d34aa79061c949dd6d579fc47055cd4R97

Which solves this by adding flex grow (through flex) on the container which overflowed the parent on android.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sameerlaul commented 4 years ago

since this issue is already resolved in PR #1335, I am closing this PR