search

Path-Check / safeplaces-dct-app

COVID Safe Paths (based on Private Kit) is an open and privacy preserving system to use personal information to battle COVID
https://covidsafepaths.org
MIT License
466 stars 285 forks source link

Add automated lokalise import #1356

Closed javierpena closed 3 years ago

javierpena commented 3 years ago

Description:

This commit adds a GitHub action to pull the latest lokalise data and generate a pull request with it. It is scheduled to run every 4 hours.

Linked issues:

Fixes SAF-212

Screenshots:

#### How to test: Once merged, we should see the PR coming/being updated every 4 hours, if any lokalise data has been updated. Alternatively, we could test it by adding "on: \n workflow_dispatch:" to the GitHub workflow definition, so we can run it on demand instead of a fixed schedule.
alpita-masurkar commented 3 years ago

@javierpena This is super! But just remember that there are sometimes errors in translation in Lokalise and sometimes, variables/configurable parameters are not added appropriately inside the translated text in Lokalise. This means that the customizable variable might not show up correctly in those languages. The content should be reviewed for any of these things before such a PR is merged.

javierpena commented 3 years ago

@alpita-masurkar thanks for the review.

Sure, this action will always create a PR, which should then be reviewed. It will not merge it on its own.

Maybe I can modify the action configuration, so the commit message states this?

alpita-masurkar commented 3 years ago

@javierpena yes, that sounds perfect! thanks once again Javier.

javierpena commented 3 years ago

Thanks @alpita-masurkar, I have updated the PR.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

javierpena commented 3 years ago

So this PR is not getting merged?