Path-Check / safeplaces-dct-app

COVID Safe Paths (based on Private Kit) is an open and privacy preserving system to use personal information to battle COVID
https://covidsafepaths.org
MIT License
465 stars 283 forks source link

Implement 'findNewAuthorities()' #375

Closed Patrick-Erichsen closed 4 years ago

Patrick-Erichsen commented 4 years ago

I was poking around in the codebase and noticed the commented instructions for building out findNewAuthorities() in LocationTracking.js.

I'm looking for a good first issue to tackle and thought I'd give this a go.

@penrods, it looks like you added the comments. Mind if I assign this to myself?

Outline

Patrick-Erichsen commented 4 years ago

If this work is a blocker on any other issues please let me know - I have experience developing React & React Native Web, but I'm pretty new to React Native and mobile in general. I don't want to hold anything else up if it takes longer than I anticipated.

Patrick-Erichsen commented 4 years ago

I spent a few hours today trying to figure out how to test rn-fetch-blog but couldn't get it to work.

I wanted to pull down our list of HCAs and verify that we're returning a valid YAML file that has an Authorities list, but it doesn't seem like there's a clean way to actually call RNFetchBlob in Jest without just mocking out the entire module (https://github.com/wkh237/react-native-fetch-blob/issues/212).

If anyone has any thoughts on how to test this cleanly let me know.

penrods commented 4 years ago

Closing this one in favor of #425.