search

Path-of-Terraria / PathOfTerraria

GNU General Public License v3.0
1 stars 3 forks source link

Blacksmith #223

Closed GabeHasWon closed 4 months ago

GabeHasWon commented 4 months ago

### Link Issues Resolves: #169

Description of Work

Adds in Blacksmith NPC. Adds in Broken Anvil & Furnace tiles. Adds in Forging a New Blade quest (unfinished).

Comments

Blacksmith NPC has a temporary sprite but it's been held up here for a while, and I suspect it'll be held up for a long time yet anyway. Instead of waiting to merge when the sprite is finished, we can merge and add in the sprite when it's done. Similarly, the associated quest here is not finished as it was not tested due to lack of quest book UI at the time of its creation. This can be easily remedied now, but the quest is not a core part of functionality and can be updated at any moment.

I just want to make sure the NPC-related organization is consistent for future work on main without having to look at other branches.

Finally, associated building is not attached to this PR, and is instead hosted on the building server. This will likely be the case with all buildings until we decide to make the town proper.

GabeHasWon commented 4 months ago

The quest is now - from what I can tell, fully functional, ignoring the repairing of the building. I don't yet have the building, and I'd like to test it alongside each stage properly instead of using a placeholder.