search

Path-of-Terraria / PathOfTerraria

GNU General Public License v3.0
1 stars 3 forks source link

Vanilla Item Cloning - Swords #242

Closed CollinHerber closed 4 months ago

CollinHerber commented 4 months ago

Summary

Clone all of the sword using the VanillaClone class from #238

Reasonings

This ticket will specifically cover https://terraria.wiki.gg/wiki/Weapons#Swords

GabeHasWon commented 4 months ago

Alright, so I've been doing all of these. A lot of vanilla's swords have hardcoded (i.e. if (type == vanillaId)) visuals and effects. I've gotten through all of them so far, but the Breathing Reed (of all things) has an issue. For some reason, there's no API for modifying the breath variables in players. breathCDMax, which controls the speed of how quickly you run out of breath, is a get-only property which is small enough to be inlined. As such, I'd have to mass patch every time breathCDMax is used, which is simply not happening. Do we care enough to replicate that? I've already replicated it allowing you to be under water and breathe through it, just not it making it let you stay under for longer.