search

Path-of-Terraria / PathOfTerraria

GNU General Public License v3.0
1 stars 3 forks source link

Create CriticalAffixes.json #383

Closed ckeyboard closed 1 month ago

ckeyboard commented 1 month ago

Description of Work

Adds the following affixes:

  1. PercentageIncreasedCriticalStrikeChance
  2. PercentageCriticalStrikeMultiplier
  3. FlatCriticalStrikeChance
  4. PercentageIncreasedCriticalStrikeDamage

Comments

CriticalAffixes.json should now be in the correct directory.

CollinHerber commented 1 month ago

It looks like this adds them to the available pool but I'm not seeing the actual implementation of the functionality for the affixes.

The affixType should match to the class name for the logic. Take https://github.com/Path-of-Terraria/PathOfTerraria/blob/89e107ee4d3ee72f6865b7b1b49efc171c6b4287/Common/Data/Affixes/DefenseAffixes.json#L3 for example points to https://github.com/Path-of-Terraria/PathOfTerraria/blob/f312d64de33fd477f5027b426540bcc157e0b52b/Common/Systems/Affixes/ItemTypes/DefenseAffixes.cs#L3

ckeyboard commented 1 month ago

For consistency, should the new affixes end with an "affix" suffix?

CollinHerber commented 1 month ago

For consistency, should the new affixes end with an "affix" suffix?

It's easier to search so id say yes