search

Path-of-Terraria / PathOfTerraria

GNU General Public License v3.0
1 stars 3 forks source link

Glimmering shard #439

Closed GabeHasWon closed 3 weeks ago

GabeHasWon commented 3 weeks ago

### Link Issues Resolves: #437

Description of Work

GabeHasWon commented 3 weeks ago

Is the shard stackable and when using the item on it, it only consumes a single stack?

Correct, You can reroll your desired item as fast as you can right click. The only issue I foresee is that you can't see the affixes you just rerolled; you have to pick up the item, right click the shard, put the item down, look at the tooltip, and repeat. Not super sure how to solve this; for now it could just be posting in chat "Rerolled affixes to: Increased Damage, Increased Knockback" until we have something nicer.

CollinHerber commented 3 weeks ago

Is the shard stackable and when using the item on it, it only consumes a single stack?

Correct, You can reroll your desired item as fast as you can right click. The only issue I foresee is that you can't see the affixes you just rerolled; you have to pick up the item, right click the shard, put the item down, look at the tooltip, and repeat. Not super sure how to solve this; for now it could just be posting in chat "Rerolled affixes to: Increased Damage, Increased Knockback" until we have something nicer.

I think it's worth spending the extra time to solve this now since this initial ticket is including the base foundation for crafting items in the game. The first thing that comes to mind is a window that is placed next to the cursor, that moves with the cursor, that is a picture of the item you have picked up. This would appear on anything that bases from Gear that is seen only when the item is "picked up" IE left clicked and being moved somewhere since we have tooltips to cover the other cases

GabeHasWon commented 3 weeks ago

I could do that, sure. Will get on it right away.

GabeHasWon commented 3 weeks ago

Alright, I finished the tooltip hover. image Might move it a bit to make it not overlap the item. That being said, my "fix" of not creating shallow copies of the list in Clone now makes it so affixes are immediately deleted entirely. I don't know how making it shallow copy during loading then make it copy reference is fine, but copy reference always breaks it completely. I see no reason this PR doesn't work in its functionality though, so I'll seek to solve whatever affixes are doing elsewhere.