Separation of Differences & Stats on Affixes

[CollinHerber]

Summary

By looking at this , it's not super indicative of what stats are on the item vs what is being replaced.

I think the differences should be displayed only when holding shift on the item. And they should be under the affix texts themselves

Reasonings

Easier to digest tooltips

[GabeHasWon]

Not yet done, but this is [close to] how the comparison tooltip will look like. I don't know why the backing slots show on the item tag, never seen that before, but that should (HOPEFULLY) be a pretty easy fix. You can see all of the affixes given from the item are at the top (including if other items modify them, such as the topmost one here), which may be confusing as it's still not super clear. There'll be a non-comparison thing when shift isn't held that's just the item's affixes alone, which should alleviate all confusion.

[GabeHasWon]

So it's easier to do this - compared stuff is still shown, but only on the affixes the item has. All of the shown affixes here are on the Rusted Battleaxe, as you can see, but the Broadsword I'm holding also adds some attack speed. Would this be fine?

[GabeHasWon]

Fixed the backing slot issue, and made it so only affixes with competing sources can appear as "from" items.

[CollinHerber]

This looks interesting. Not what I was envisioning. In the picture with the 6.69% attack speed (+5.33) from..

Does that mean the axe has 5.33% and the sword has 12.02%?

In this example the sword ONLY has 12.02% attack speed and that is it right? The axe has the attack speed + fetid + 6.66% damage to poisoned enemies?

[CollinHerber]

Additionally, skills should be rounded to the nearest whole number. Want me to create a separate ticket to address that?

[GabeHasWon]

Yeah, make a separate ticket for that. Though, those skill affixes shouldn't be rolled on just any item either, right? We don't have system for disabling that. Feels dumb to have uniques that add +1, and then have some random item have +5.

As for the tooltip, it marks the sword first. The comparison is then using the "base" value of the Sword, which is ~1.36%, which the Axe beats by 5.33%. It is not combining the strength of both; the Axe simply has an affix value of +6.69%, and since it's a weapon, it'd replace the held weapon's affix strength. Otherwise, yeah, the axe has +6.69% attack speed, +5.4 Carapace, and +6.66% damage to poisoned enemies.

[CollinHerber]

We don't have system for disabling that.

We should yes. The affix registry should only be applying affixes that are listed in the json data. If the affix is not listed in the json for that particular item, it should not be rolling.

As for the tooltip, it marks the sword first.

I think this system has a potential to be quite confusing then. I think it would be better to just simply have the % differences listed underneath everything and not be intertwined with the actual properties themselves.

IE if you are hovering the weapon in your inventory (not hotbar slot 1) it will list only the properties for that weapon. No comparisons yet. Upon hitting shift an entirely new section appears that is the differences between the two items. Simply have the - or + listed, don't need the stats from the individual weapons. I realize that kinda backpedals a lot of work but that was my fault for not being explicit.

Unless you have a different idea ofc.

[GabeHasWon]

Upon hitting shift an entirely new section appears that is the differences between the two items. Simply have the - or + listed, don't need the stats from the individual weapons.

Couple of things to note.

1. It doesn't list the stats of individual weapons/gear at all.
2. More than 2 items can have the same affix(es), i.e. all armor + all 4 accessories giving +defense or something. Would this change anything?
3. Would the comparison tooltips change? Being in the format of final bonus for stat (+/- difference for hovered item) from Item1, Item2...ItemN

I should be able to make a clean, plain tooltip menu for non-comparison though, it's just a notable amount more work than it was as-is.

[CollinHerber]

It doesn't list the stats of individual weapons/gear at all.

If you don't have an item in the slot you are going to see the item's base stats. I'm suggesting it always does this by default and doesn't show any comparisons until you actually hold shift.

More than 2 items can have the same affix(es), i.e. all armor + all 4 accessories giving +defense or something. Would this change anything?

Not sure what you mean. You'd only ever see the armor/weapon/accessory you'd be replacing when holding shift so it would only be comparing a single item at a time.

Would the comparison tooltips change?

I'm assuming this relates to number 2 somehow? I'm confused by this question as well.

[GabeHasWon]

If you don't have an item in the slot you are going to see the item's base stats. I'm suggesting it always does this by default and doesn't show any comparisons until you actually hold shift.

Oh, I just interpreted this differently. I thought that you were saying it did something like, +2 defense from Helmet, +3 defense from Chestplate, +16 defense from Leggings... or something. Agreed, that's what I'll do.

Not sure what you mean. You'd only ever see the armor/weapon/accessory you'd be replacing when holding shift so it would only be comparing a single item at a time.

Let's assume there's an affix that can be applied to any Gear. If I have a full set where everything has that affix, let's say +10 units per affix, the comparison tooltip would show +110 (+0) for that affix as you have ~11 things applying +10 and the replacement would be the same value as not replacing. If the replacement has less, it'd be +110 (+5) or something, combining every other value into one and noting the benefit of the replacement. Basically, it's "comparing" two items but includes all relevant items. Is that the intent?

I'm assuming this relates to number 2 somehow? I'm confused by this question as well.

Yeah, basically just a continuation of the above. If that's not the intent, it'd need to change pretty substantially. For example, you might want a comparison to be the difference between only the two items that could be interchanged (i.e. stats if I replace helmet X with helmet Y, but NOT including the stat(s) from chestplate).

[GabeHasWon]

Fixed the non-comparison page.

[CollinHerber]

Basically, it's "comparing" two items but includes all relevant items. Is that the intent?

The comparison should only include the item you are replacing. Not any of the gear. If you are replacing something that has +5 defense with something that has +8 defense it should only show +3 defense in green in the comparison area marked as green.

the comparison tooltip would show +110 (+0) for that affix

This shouldn't be the case, only + what it will be modifying from the item you are replacing. Does that makes sense?

Fixed the non-comparison page.

The non-comparison page doesn't need to have any colors. Only the comparison needs the green & red coloring. I realize this isn't how it was just saying this is how it should be if it's not going to compare there.

For example, you might want a comparison to be the difference between only the two items that could be interchanged (i.e. stats if I replace helmet X with helmet Y, but NOT including the stat(s) from chestplate).

This sounds exactly like what I'm thinking. The other non-effected items should not be included in the comparison. I thought that is how it works currently? I've not seen it list other affixes from other sources if it won't be replacing it.

[GabeHasWon]

Whoops, missed this and used the downtime to fix the backing panel for tooltips being overlong. Apparently, vanilla doesn't run the hook that modifies the tooltip scale until LONG after drawing the backing panel. That's really dumb! Fixed though.

The non-comparison page doesn't need to have any colors. Only the comparison needs the green & red coloring. I realize this isn't how it was just saying this is how it should be if it's not going to compare there.

I don't understand the last sentence at all. Personally, I think it should keep the colors. Green = beneficial, always good to make that clear. Corrupt affixes would also need an exception. Finally, we could in the future have negative affixes (i.e. powerful items that give +50% damage, -50% defense) which would benefit from a color. We don't really gain anything from removing the color.

[CollinHerber]

There is not a single affix that isn't beneficial. Therefor it would always be green. That's just adding unnecessary color.

[GabeHasWon]

I don't think it's unnecessary. Especially to new players, they'd see +xyz and it'd show that it's a new thing (not just prefixes or normal accessory stuff) and that it's good. We lose nothing from keeping it green.

[CollinHerber]

Agreed, we lose nothing. Maybe it's just I'm a fan of not being overstimulated by a billion colors or something. If you feel that strongly about it, I don't, keep it

[GabeHasWon]

I'll keep it then. It just keeps the corrupt color without an exception and that's preferable.

This more like it? For some reason all of my gear (aside from the Battleaxe) have the same affixes, but only the Sniper (hovered) and Corrupt Battleaxe (held) shown.

[CollinHerber]

Can you show me what the non-shift version looks like?

[GabeHasWon]

[CollinHerber]

Yea I still don't think this is what I am envisioning....

Lets take the two items.

Sniper Rifle +5 Damage +1 Blood Siphon +1% Change to Apply Blodclot

Battleaxe +8 Damage +5% Attack Speed +5 Life

I have the Battleaxe Equipped Curently. I am hovering the Sniper Rifle in my inventory. I am NOT holding shift.

My tooltip should look as follows

Sniper Rifle
+ Item Level: 30
* [148-222] Damage (ranged damage)
* +5 Damage
* +1 Blood Siphon
* +1% Change to Apply Blodclot
(Hold shift to compare stats)
Shoots a powerful, high velocity bullet

Changes required:

• The space between ( and r in ranged damage needs to be removed
• Hold shift need to be moved

I have the Battleaxe Equipped Curently. I am hovering the Sniper Rifle in my inventory. I AM holding shift.

My tooltip should look as follows

Sniper Rifle
+ Item Level: 30
* [148-222] Damage (ranged damage)
* +5 Damage
* +1 Blood Siphon
* +1% Change to Apply Blodclot
Equipping the Sniper Rifle would:
-3 Damage
-5% Attack Speed
-5 Life
+1 Blood Siphon
+1% Change to Apply Blodclot

Shoots a powerful, high velocity bullet

Changes required:

• The top section that contains the stats of the item you are hovering remains unchanged.
• The (Hold shift to compare stats) is updated to Equipping the Sniper Rifle would:
• The - stats are listed first.
• The + stats are listed after the - stats.
• Any stats that are shared are inserted in the correct place if they are a - or +

[CollinHerber]

I'm sorry for the trouble. I really should have articulated this better. I was very vague in my "Separation" remark. But if I was confused and I know how the items and affixes work, people would be hella confused as we are introducing a whole new genre of game to terraria players.

[GabeHasWon]

Alright, that is not how I programmed this entire system to work. I'll figure it out though lol Non-compare screen is good to go though.

[GabeHasWon]

More like this? I don't think you want the +x (+/-y) format that's currently there, but this seems to be closer to what you want.

[GabeHasWon]

Ok, to my knowledge, this perfectly recreates the sample you gave me. It works on all gear types. Note: This is redundant. I assume this'd be removed if there's no differences?

[CollinHerber]

Ok, to my knowledge, this perfectly recreates the sample you gave me. It works on all gear types. Note: This is redundant. I assume this'd be removed if there's no differences?

I'd say that looks exactly what I was envisioning. Might want to move the flavor text for the unique before the properties though. Right under item level

[GabeHasWon]

Like this then?

[CollinHerber]

Looks good to me. I think it just needs some padding on the bottom

[GabeHasWon]

Fixed the redundant "comparison" page with no comparisons. It'll say "(Nothing to swap)" if you're attempting to compare an item with nothing to compare to.

The padding is weird...I have that fix that should properly detect the size but it just...doesn't. I think it's inconsistent? Falling back to an alternative which seems to fit better. Not perfect, but a larger back panel is better than a clearly short one.

[CollinHerber]

Looks perfect