Separation of Differences & Stats on Affixes

[CollinHerber]

Summary

By looking at this , it's not super indicative of what stats are on the item vs what is being replaced.

I think the differences should be displayed only when holding shift on the item. And they should be under the affix texts themselves

Reasonings

Easier to digest tooltips

[GabeHasWon]

Not yet done, but this is [close to] how the comparison tooltip will look like. I don't know why the backing slots show on the item tag, never seen that before, but that should (HOPEFULLY) be a pretty easy fix. You can see all of the affixes given from the item are at the top (including if other items modify them, such as the topmost one here), which may be confusing as it's still not super clear. There'll be a non-comparison thing when shift isn't held that's just the item's affixes alone, which should alleviate all confusion.

[GabeHasWon]

So it's easier to do this - compared stuff is still shown, but only on the affixes the item has. All of the shown affixes here are on the Rusted Battleaxe, as you can see, but the Broadsword I'm holding also adds some attack speed. Would this be fine?

[GabeHasWon]

Fixed the backing slot issue, and made it so only affixes with competing sources can appear as "from" items.

[CollinHerber]

This looks interesting. Not what I was envisioning. In the picture with the 6.69% attack speed (+5.33) from..

Does that mean the axe has 5.33% and the sword has 12.02%?

In this example the sword ONLY has 12.02% attack speed and that is it right? The axe has the attack speed + fetid + 6.66% damage to poisoned enemies?

[CollinHerber]

Additionally, skills should be rounded to the nearest whole number. Want me to create a separate ticket to address that?

[GabeHasWon]

Yeah, make a separate ticket for that. Though, those skill affixes shouldn't be rolled on just any item either, right? We don't have system for disabling that. Feels dumb to have uniques that add +1, and then have some random item have +5.

As for the tooltip, it marks the sword first. The comparison is then using the "base" value of the Sword, which is ~1.36%, which the Axe beats by 5.33%. It is not combining the strength of both; the Axe simply has an affix value of +6.69%, and since it's a weapon, it'd replace the held weapon's affix strength. Otherwise, yeah, the axe has +6.69% attack speed, +5.4 Carapace, and +6.66% damage to poisoned enemies.

[CollinHerber]

We don't have system for disabling that.

We should yes. The affix registry should only be applying affixes that are listed in the json data. If the affix is not listed in the json for that particular item, it should not be rolling.

As for the tooltip, it marks the sword first.

I think this system has a potential to be quite confusing then. I think it would be better to just simply have the % differences listed underneath everything and not be intertwined with the actual properties themselves.

IE if you are hovering the weapon in your inventory (not hotbar slot 1) it will list only the properties for that weapon. No comparisons yet. Upon hitting shift an entirely new section appears that is the differences between the two items. Simply have the - or + listed, don't need the stats from the individual weapons. I realize that kinda backpedals a lot of work but that was my fault for not being explicit.

Unless you have a different idea ofc.

[GabeHasWon]

Upon hitting shift an entirely new section appears that is the differences between the two items. Simply have the - or + listed, don't need the stats from the individual weapons.

Couple of things to note.

1. It doesn't list the stats of individual weapons/gear at all.
2. More than 2 items can have the same affix(es), i.e. all armor + all 4 accessories giving +defense or something. Would this change anything?
3. Would the comparison tooltips change? Being in the format of final bonus for stat (+/- difference for hovered item) from Item1, Item2...ItemN

I should be able to make a clean, plain tooltip menu for non-comparison though, it's just a notable amount more work than it was as-is.