search

Path-of-Terraria / PathOfTerraria

GNU General Public License v3.0
1 stars 3 forks source link

Max Health Multiplier Equipment Hides Health Bars #473

Closed CollinHerber closed 1 week ago

CollinHerber commented 3 weeks ago

Description

See Video: https://chicksgold.gyazo.com/3aae4d0dfa6f0420d4c69109ea7046c9

Something wrong with the "Max Health Multiplier" affix. It appears to hide the affix. Additionally there appears to be a few extra affixes for life.

I think there should only really be "AddedLifeAffix" and "IncreasedLifeAffix"

Not sure what "BaseLifeAffix" and "FlatLifeAffix" should be doing.

It really should be as simple as if the player has 100 life by default, and they have 50 added life. It should calculate the Added Life + Plus their Base Life First (So 100 + 50) and THEN the "IncreasedLifeAffix" is evaluated.

So if they had 50% increased life from their affixes they'd get an additional 75 health (50% of their new calculated life) Totaling 225 Life

Reproduction steps

No response

Screenshots

No response

Logs

No response

GabeHasWon commented 1 week ago

Ok, fixed the UI hiding issue. MultipliedLifeAffix was multiplying by bonus instead of 1 + bonus, making a +6% increase actually a 94% decrease.

As for the other affixes: Base is additional flat life before multipliers; Flat is a flat addition to the end value, no multipliers; AddedLifeAffix vs MultipliedLifeAffix is confusing because of how StatModifier is set up; I believe the way it works is someStatModifier += 0.1f; would be a 10% increase - internally known as the Additive modifier. someStatModifier *= 1.1f, however, would be a multiplier on the Additive modifiers as well as the base value. It's really confusing but there is a substantial difference there.

We can probably axe Flat without issues as it's just Base but worse, but the rest do have some merit to living.

Oh, and for the equation, that's how it works already.

CollinHerber commented 1 week ago

Having "worse" affixes isn't a bad thing. We want a very large pool of affixes, so the pool is diluted and people actually have to work for their end-game gear. That said if it's just a clone then definitely axe it, sounds like it's not though.

Sounds like the only thing thatt needs to happen here is just the MultipliedLifeAffix fix then?

GabeHasWon commented 1 week ago

Flat vs Base is not a clone and has the tiniest of differences, so it'll stay then. All of these are (if slightly) unique, so they all stay.

I've already pushed the fix to the max-health-affix-fix branch. I'll open up a PR right now.