PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.97k stars 2.08k forks source link

Error when mouse over minion crit stats when "enemy on consecrated ground" is ticked #1311

Closed Dodgy-J closed 4 years ago

Dodgy-J commented 4 years ago

When "Is the enemy on Consecrated Ground?" is ticked. On the Calcs tab, showing minion stats, when you mouse over the crit stats it throws an error, I think its because source is nil. I believe the line that needs to be changed is the following, from Config Options modList:NewMod("MinionModifier", "LIST", { mod = modLib.createMod("CritChance", "INC", 100, { type = "ActorCondition", actor = "enemy", var = "OnConsecratedGround" }) }, "Config")

I think it should be modList:NewMod("MinionModifier", "LIST", { mod = modLib.createMod("CritChance", "INC", 100, "Config", { type = "ActorCondition", actor = "enemy", var = "OnConsecratedGround" }) })

It fixed it for me, but im not sure/familiar enough with the code to pull request it.

Regisle commented 4 years ago

Known issue already fixed by #1301 which has been merged onto dev, ty for the detailed report and yeah your fix is the correct one

also reported at #1308

ppoelzl commented 4 years ago

Duplicate of #1308