PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.88k stars 2.09k forks source link

Second "#of beams" window for Storm Rain when used in dual setup (self-cast and with ballista totems) #3085

Open Ydoum opened 2 years ago

Ydoum commented 2 years ago

Check for duplicates

Is your feature request related to a problem?

When two separate Storm Rain setups are present in a build, only one "# of overlapping beams" window is available. This generates incorrect DPS values, as the two skills have different damage calculations based on different supports, but they both use the same window.

Describe the solution you'd like

Enable a second window for the number of beams when a skill setup with a ballista totem + storm rain is present alongside self-cast storm rain.

Describe alternatives you've considered

An alternative workaround could be for the single window to count overlapping beams of all Storm Rain instances at once, but I don't see how it would correctly calculate DPS for those said instances.

Additional context

Current PoB for reference: https://pastebin.com/bpCdMzBY

Ydoum commented 2 years ago

I just wanted to add that a possible third window for Mirage Archer might be required. Setting up a beam count in a single window also affects the Full DPS value of MA, which should not be the case considering how much reduced its attack speed is.