Ballista Totem Support not called "Ballista Totem Support"

PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.

https://pathofbuilding.community

Other

3.63k stars 2k forks source link

Ballista Totem Support not called "Ballista Totem Support" #3227

Open pHiney opened 2 years ago

pHiney commented 2 years ago

Check version

[X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

[X] I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

REF: a. https://pathofexile.fandom.com/wiki/Ballista_Totem_Support b. In Game.

What is the actual behaviour/value?

Match the name please

How to reproduce the issue

Build code

N/A

Screenshots

No response

Voronoff commented 2 years ago

All support gems are missing the "Support" suffix in their name. I will fix.

Lothrik commented 2 years ago

This isn't a bug. The word "support" is intentionally removed from all support gems in the export scripts: https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/dev/src/Export/Scripts/skills.lua#L171

This could be changed but I'm not sure why anyone would want to. You're already able to search for gems by tag (e.g.: Ballista Totem Support shows up as Bow, Projectile, Support, Totem).

pHiney commented 2 years ago

Because people come from looking at the game and don't see what you see in game We should match in-game. Do items get renamed ?

Lothrik commented 2 years ago

I just imported my old Ballista Totem character from Standard and it worked perfectly fine:

ZzZombo commented 2 years ago

This isn't a bug. The word "support" is intentionally removed from all support gems in the export scripts: dev/src/Export/Scripts/skills.lua#L171

This could be changed but I'm not sure why anyone would want to. You're already able to search for gems by tag (e.g.: Ballista Totem Support shows up as Bow, Projectile, Support, Totem).

Sorry, but I respectfully disagree. This is a misfeature. It honestly looks to me like one of instances where it looks OK to a programmer because it totally makes sense to him to remove the suffix, simply because he likes it this way more and he could do it and so he does. First, it does makes it hard to tell support gems apart from active gems. Second, it leads to collisions like between the Barrage and Barrage Support gems. And third, it does not bring anything positive as far as I can see.

Wires77 commented 2 years ago

Related: #1083 This is a very old discussion. Support gems used to not have "Support" appended to their name, so PoB was originally written with this in mind. In the game data, where we get the names of gems, we remove it because it was much easier to remove "Support" than it was to change every place that referenced the gem's name (e.g. searching) and test it so it won't break. Barrage support didn't exist at that time, either, so leaving "Support" on the end would've been a visual benefit only. We'll have another discussion on this but it's incredibly low in priority (as evidenced by the age of the related issue) even if it does end up getting done.