Instead of dropdowns for masteries, use a list

PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.

https://pathofbuilding.community

Other

3.97k stars 2.07k forks source link

Instead of dropdowns for masteries, use a list #3440

Closed ufuksarp closed 2 years ago

ufuksarp commented 2 years ago

Check for duplicates

[X] I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Current implemention of selecting masteries is tedious and unintiutive.

Describe the solution you'd like

Use an open list, not a dropdown. Click the mastery you want, and the list goes away. Clicking outside the list makes it disappear. Get rid of 2 clicks per one mastery selection.

Describe alternatives you've considered

Additional context

pHiney commented 2 years ago

I agree, the dropdown doesn't show everything quickly/easily. I'll look over the code over the next day and see what i can come up with. Should not be too hard.

ufuksarp commented 2 years ago

Another thing with it though: PoB font is thin, badly anti-aliased and so small, it's very hard to read. If you can manage to do it, please add slight padding between list items so it might be a precedent for future updates for better readability. These paddings should be extensions of the list items, meaning clickable.

pHiney commented 2 years ago

https://youtu.be/73NPDcYzQPQ simple preview. I don't know why the graphics is so bad. but it's enough to show what i'm doing.

I will look into the padding now

pHiney commented 2 years ago

Padding will be tricky. I've increased the size of the font. I'll check for changing the colour of the selected row and auto width.

ufuksarp commented 2 years ago

Looks good. Can it be one left click to open the list and one left click to select and assign? Also is it possible to get rid of the scrollbar which has no use?

Antorell commented 2 years ago

That list looks good. The current implantation on a 4K monitor with scaling to 175% looks like a PoB for the ants.

pHiney commented 2 years ago

"Can it be one left click to open the list and one left click to select and assign" yes it could, I'd be concerned for usability and accidentally assigning things. I think there needs to be an element of surety when using the mouse. "scrollbar". I'm working on that cause i don't like it either - but IRL i have other things to do :-)

pHiney commented 2 years ago

seems Voronoff has done this already #3476

ufuksarp commented 2 years ago

"Can it be one left click to open the list and one left click to select and assign" yes it could, I'd be concerned for usability and accidentally assigning things. I think there needs to be an element of surety when using the mouse. "scrollbar". I'm working on that cause i don't like it either - but IRL i have other things to do :-)

I don't think that's a big deal to let the user learn. It's much faster to do it this way instead of bonus clicks which really has benefit.

LocalIdentity commented 2 years ago

Fixed in 2.12.0