Tawhoa, Forest's Strength not affecting the dps

Genhain commented 2 years ago

Check version

[X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

[X] I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

When allocating/deallocating this node for chieftan i expect to see it affect the DPS values

What is the actual behaviour/value?

when allocating/deallocating this node the DPS values remain unchanged/unaffected

How to reproduce the issue

allocate deallocate Tawhoa, Forest's Strength

Build code

https://pastebin.com/WxjSYT00

Screenshots

No response

pHiney commented 2 years ago

Why do you think there should be DPS change. It summons a minion.

https://pathofexile.fandom.com/wiki/Tawhoa,_Forest%27s_Strength?so=search

pH

PJacek commented 2 years ago

Mirages work more like totems rather than minions. Tawhoa's Chosen should behave similar to General's Cry but this requires "linking" it to every slam skill somehow and writing custom "trigger on attack" logic.

QuickStick123 commented 1 year ago

Fixed in https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4599

QuickStick123 commented 9 months ago

The notable is now supported but as it is a separate skill it doesn't show up as a dps change not sure if too close this or not.

PathOfBuildingCommunity / PathOfBuilding