Lothrik
commented
2 years ago Open CyborgDitz opened 2 years ago
Lothrik
commented
2 years ago 
CyborgDitz
commented
2 years ago Oh I didn't find it when searching, my bad
On Sat, 25 Jun 2022, 03:42 Lothrik (MaXiMiUS), @.***> wrote:
4241
https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4241 is related to (and directly addresses) basically all of this, but it has unresolved issues at the moment and I'm not sure when I'll get around to working on them. Commenting so I remember to close this issue at some point in the future.
— Reply to this email directly, view it on GitHub https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/4462#issuecomment-1166167114, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZUZ7JMZXVQFT7I4ZXBBOCTVQZPX3ANCNFSM5Y4VT6PA . You are receiving this because you authored the thread.Message ID: @.***>
Check for duplicates
Is your feature request related to a problem?
The Death Wish skill actualy has two damage components and not just one, but PoB only calculates one (and with wrong parameters).
There are mixed damages, one is base fire damage from the skill and then secondly the minion explosion (this explosion cannot be reflected but the base one can).
The base is buffed by spell damage increases, and fire.
As evidenced by enabling and disabling Herald of Fire, or even zealotry as seen here
However, in POB neither aura increases damage, or crit chance even though spell crit chance increases crit as seen above. And increasing the health or levels of minions doesn't increase the calculated damage in pob, neither can you select which minions that explode.
As is, the Death Wish skill doesn't calculate correctly and actually does way different damage as written in PoB.
Describe the solution you'd like
Dividing the damage components of Death Wish Base damage and minion explosion, and enabling choice of what minion explodes. Fixing so increasing health and levels of minion will add damage to the minion explosion. Adding so spell damage and elemental damage increases adds damage to the base explosion. Adding that spell crit chance also increases crit chance of the spell.
Describe alternatives you've considered
The alternative is using a spread sheet of minions and adding life to them, finding the base damage of the death wish explosion, and adding them toghether in one boom. Not happening...
Additional context
No response