PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.94k stars 2.07k forks source link

Critical Mastery Bug with shock effect #4861

Open Creatonism0 opened 2 years ago

Creatonism0 commented 2 years ago

Check version

Check for duplicates

What is the expected behaviour/value?

When clicking on Critical Mastery, and selecting "50% increased effect on non damaging ailments you inflict with a critical strike", and I'm at 100% crit chance, I expect my ailment multiplier for shock to be increased

What is the actual behaviour/value?

When that same mastery is allocated, it changes no values, even at 100% crit chance, for shock value. I was at 3.75 ailment multi before allocating the node, and remained at 3.75 after.

How to reproduce the issue

Simply setting crit chance to 100 and allocating the node with a shocking skill equipped should be able to easily replicate the bug

Character build code

https://pobb.in/fSN3jArINEjk

Screenshots

image image image image

dyfrgi commented 11 months ago

As a temporary improvement for this, could the color of the mod be changed to red? Since PoB does not actually support it.

BenoitV5000 commented 5 months ago

I ran into this same issue today. I tested with every non-damaging ailments (chill, freeze, shock, brittle and sap), the critical mastery doesn't work for all of them.

An easy workaround is to add the line "50% increased Effect of Non-Damaging Ailments" in the Custom Modifiers textbox located all the way to the right in the Configuration tab.