PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.99k stars 2.08k forks source link

Warcry Calculation Mode Is Incorrect #4884

Open TwoStonedBrilliance opened 2 years ago

TwoStonedBrilliance commented 2 years ago

Check version

Check for duplicates

What is the expected behaviour/value?

When im looking at the configuration by default warcry mode is set to "Max hit" Now I only have 1 warcry on my POB, Infernal Cry What it's supposed to do is simply - cover enemies in ash (this does not stack and it's inc fire dmg taken is based on the warcry power) It also "combusts" which is a hit that deals 157% of base with 60% converted to fire

So it should NOT be getting more powerful or more dmg when reaching the "final" exert Max Hit on Warcry calculation mode shows "Shows maximum hit for lining up all warcries"

When I put it on average my ignite dps PLUMMETS to nearly nothing

On max, my ignite dps is absolutely monstrous

If I disable infernal cry then the warcry calculation mode is gone and my dps is massive

So the "Average" mode for warcry calculation is completely bugged/useless

The "Max" might be working properly but I really don't know

What is the actual behaviour/value?

When I select Warcry Calculation mode and put it on avg it destroys my damage values Less dmg than turning the warcry off completely, which makes no sense

How to reproduce the issue

Set a melee ignite build pob Enable any war cry Go to Calc and set warcry mode to avg instead of max Watch dps plummet to nothing

Character build code

https://pastebin.com/jBmsyc6M

Screenshots

No response

Regisle commented 2 years ago

alot of things use averages when they probably shouldnt, I am planning on fixing this when reworking repeats