PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.99k stars 2.08k forks source link

Siegebreaker disappears from damage calc/drop down menu when you catalyst it. #5080

Open jc2008 opened 2 years ago

jc2008 commented 2 years ago

Check version

Check for duplicates

What is the expected behaviour/value?

Siegebreaker Heavy Belt/Replica Siegebreaker Heavy Belt have a mod "Your minions spread burning ground [caustic ground] on death, dealing x% of their maximum life as fire[chaos] damage per second"

When you use a turbulent catalyst (on replica) or noxious catalyst (on normal) it raises the % of their maximum life they do. I expect PoB to recognize this and calculate it accordingly.

What is the actual behaviour/value?

The belt's extra damage from the on death effect of minions no longer shows up in the dropdown menu on PoB under the minion's damage type and it's not included in the overall damage anymore. If you have a belt with no catalysts on it, then in Summon Raging Spirit's dropdown menu you will see the default attack and the burning [caustic] ground, depending on if you have a normal or replica.

When you + the belt with the catalyst that ups that mod's damage, PoB ignores the mod completely.

How to reproduce the issue

get a replica or normal siegebreaker belt and use the catalyst that will + up the chaos or burning damage on death mod and PoB won't recognize that mod anymore.

Character build code

https://pastebin.com/W8mXaKRd

Screenshots

https://user-images.githubusercontent.com/52169855/190311365-2aaa4450-ed39-4c32-86de-55035ba6b8ec.png

QuickStick123 commented 2 years ago

These values are hardcode in ModParser for some reason. image

Very related to https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/3193