Arcanist Brand supported skills improperly calculate effects from Elemental Overload

Polantaris commented 1 year ago

Check version

[X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

[X] I've checked for duplicate issues by using the search function of the issue tracker

Check for support

[X] I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the value from the calculation ingame?

Elemental Overload cannot trigger on skills that you do not cast yourself. Additionally, the game's tooltip indicates that "Skills that have dealt a Critical Strike in the past 8 seconds deal 40% more Elemental Damage with Hits and Ailments", implying that Elemental Overload only applies to the skill that caused the critical and it is not a character-wide bonus.

What is the value from the calculation in Path of Building?

When allocating Elemental Overload, Path of Building shows an increase in Average Hit and Hit DPS when viewing damage stats for the skill Arcanist Brand is casting.

How to reproduce the issue

Create a new build.
Create a new skill, adding Arcanist Brand and Fireball (I don't think the actual skill matters, I tried Ice Nova as well).
Set your class to Witch
Allocate the Intelligence nodes necessary to reach Elemental Overload.
When previewing allocating Elemental Overload, the game will indicate an increase in Average Hit and Hit DPS.

Character build code

eNq1W1tz2jgbvu7-CobrJBwMpNkhu0OAJMyEhoW0_faqI2wBamSLWnIS-uu_V5INhiBHxt5ctGC9x-c96GDR_fvNp5UXHHLCgutq46JereDAZR4JltfVr0-355-rf__1R3eCxOpxcRMRKkf--uNTV32uUPyCKfBVKwKFSyy-JZKcHyBpjQKxwiwYo58svGPedfULC3C1MkeBR0TyzaWI8y_Ix9fV70S4q2oFcRcHXn_3XBP6iAQz5j5jcReyaK3UvhD8OmYe0IzGk8fpU0opCdJKweZP3QlFGxzOBBIVDv9cV3vgOlrieyJAFKIRyLmqdy5a1dpx-tkaY29L2jCRTUI8XCywK8gL7odE9FcocPGWr2Piy0s7jqgga0pwuLPpom3iuH8nvFGvm4ifmEB0MJnZ4aKp2Q5Fo1wI8eqGAorWskfLgAi8R34FiQp_TuOy1bnK0vSet_H56vKiZcU8YYSzIDcG-S3tR5RCWaUZjfj1mT8nwT58lj71QoweFzoxp8gjEf84y8YoQH3Gd4FttrNIJziE0hV7HPUPGGbYZVDtuZUcZzVqeyALbE-Zy5GYIa81p_kxnNnS5RZ8mkFTaKB2lDOR6lPGOhrgNwuqUZBq2U2jbfhXmrDRbpu1vjABU9fHXqg6H95PtpTtS-M8sNpw4iI6Rm_Ej3xowE_oGQcWnA9kuRIBNAUTq2Ms2VsS4vxcfUa9E7hWiPH8bDL7LUCA2db9U9KOAteupL4GIeY4fElN0lkYL_AUEl2uAeYUW3LsVMTlYjObalVLHMT6NnbuPGDsru5g2TNFAts11JQ1zUxcJbEVrpLwCK4Z8vc5csAkGY_D1Lj4nMWUE6hhgMPlZrYimHr5qBPD-mht0e8kzmluK7z31eXKmTRrTki-o9Cz6_V5bXpBPN1XG-1suDS5XWZiWEgCg4cP1rV188Kc_ZTLcpqPrRf6LAotA66JrRxI5ocB8hWwXuTazUE3FPZBttaDVZTm4ugJgdznAfOWOJeS_ByzaL2GRiFDbssn57cp5iS14jjvWFA_Qr5ala2cCu0V7KitFWwnd3stByz2vsgJOoczO3JrFdud7hg6gg-dXm2SYVP-8T75FjY-VrseRbi_tTIXFXsFy1fyPILno4aFzG7xYjQlxMHvjbX8PXIrBcPAi0JZCtY6DjmOqXkiPnRLzgdIoArHKHRXDxDl62o19e0WUTqHyoenkqtbU6c88tPIX7NQqId9RF2uZI6CdSQqgTqi8Ql3f8yjxUKexoBMEaojpOHt7bD_NPo2jM1Is_BnQumPIPLn8vxC_79LlhlWvbDCoznXH6-r3wh-nUmuARaIUIDGZZSiNcfedXWBKAfNBD4qmhn464oMaYoKVq26-5pk7QjMkoZvOBTgL0yibkiw0a7t-AdGaYVygpVhM0mT5y1mQbqH9xEXegFgQEodaJmlyFMmoztyMIMXcgZRo-Z49AMkxGaNOcyqZEFcmfHZIX8Cak2VgYvrQrG4m4x4xzORWYY6wDIJ0INmZn2sZOKORzNQVUdaRlT1qJl9gF1k9F0Pmpm3a0oWqCPT41K2VBmSvrBAJTkUTY9QOWsYIzukeEtiFvgoVjjUU5FR0hh6VEKSWTghmUfCXMYpigys1B7XgJAcM7PqfZzBBzmW0Yn2djYGQNM0ZlF6R2BsZFms04x-Os1upclS24C8Hs3wP9ltGFyPhzNMV4sfY-jjpVRWa4B1trk1yEEzsy6t9yJEGFlKUGUwwAsMDSyzDrY0GQ1YRMEAeqXIANRSlJ7Qei-MeHqRX0iacvK4sB1SuWTp_nIUt9wS1SaoKPQHe6NS4I9P5wytP0XygSDo2fcZqwI7Sdtdwz1GVL5rYbSYwHenkIX8ZIKjwBvIow5rR7u1ZGncVasRXuGwZr7DPr_ZwM7lVvbbgxc4SEEQL1eFeqO5x5Okn4cXKKLy-T8RokRs5G4g9fRBv4cNWOhvT5tB1Iq9yiTSEuXiiEMLfXjQIz0qYmFSXeKZhiQ2SLnZUM_ih-olbG9ntfJY2U0Cl0YeHgXxpg6sIRBSiubSMvlaWR6ybgvqQM5WzacuWBMT31E2R7SZsMQvm5v16t54IxlX-4mRp_f8MEDjR2MSyBMlgf0E41_a75Fa8igMY9IJCjXFEvtydAz7DA92TDXJzWsSqJqyFz7ttPxKxeTAza3UHVAuiwKtRG6D5JGRwWJoA5HvM8iVKUZrHE97pSB0A9tFL06N43BYANALXRTAbKiEZaJwzOWEu6LZtW9dLVwlYS3JQlVauqLkx6cQ46RwlKRGnLTwJX11QJpfl4nGBQ438bpPZmIAO1Quj_mbndZZu-04zbPLK-fzWaNVbzbOnMt25-rM6bRbzbN2q9W6PGs5V5fVigC1qesNEmM3UePEJfJ1-qBDtBJizf-s1V5fXy_WSKzYAr8Rii9c5tfWwAS2n6tgnEuxtR783SzHvZur89dm_59F7-f89pnfPb6shgKGrjU0ifSuvgTBazFM4LeCSAIjP3xhsDKVY_Jh8kXBJvfP8XZ_JkKJxW_G_H8BQufy6uLKcRrtpm4O0JXFGK3jIpZUcYtp1OO-AtusAQFQQzX5JJGWlP8Dqmbzon3ZadZb-ti-q9Injlq6EiOO9bvG75DiLFCPpUp9WKAJjUT77Yky6FfAMZkDUCrO-k6J4qk0Zq9oXenNN5wjWtEIVtpVxaEzpWYn51BG8wQZOVhuGExFZdh9zP88tt9gKorw30KxPFec_JY3j1nulBC5E1Bs_hcyWiX40inBjk5JsSmc3nmCe49h6S4KmXAksTuFLchTGjBLv8hdR0GVTkldoVHYklYJ2dgooSpaOdMgd8wKKTyW-mUgl78rt4uaXXQicXIZ4G0q-iCoSM4cD2Dx3G8XlpC_-eQOeHGg2uVErFk08zoltAmnhKJzClZAq6TJt2glNsqJq5M7JVu5OYq6WtYq-pT0KSnanaLlU1K4y8rek6Y_KeiULnAiX9E4TEmwPGF5WKxzGiNXRv88MYkKQ-DkRb1RUrhb5WDfLoxA7vovqU7zWN7zI3pkidKtxcc76uxKnQ-p2yUsWJDlu7siOMD-ZkZ-44m8Vip2F0zG2CORf-R2yeHvgHYs6vdAteMqRvyGcf4h7eEvmz5k0D95Oko2ocjFK0Y9HO45q39qlFyLuUzfmj1GLy9jJDdZEibHgie5dpfwtLNZ9q8spuxLXoHE8evWDn8z9n9WplED

Screenshots

Polantaris commented 1 year ago

I noticed a similar situation with Intensify, but the game flat out says that Intensify cannot support Fireball/Ice Nova while it is connected to Arcanist Support. I don't know if I should open a separate issue for this.

QuickStick123 commented 1 year ago

I noticed a similar situation with Intensify, but the game flat out says that Intensify cannot support Fireball/Ice Nova while it is connected to Arcanist Support. I don't know if I should open a separate issue for this.

I would open an issue if there isn't already one as it sounds like a notable issue.

PathOfBuildingCommunity / PathOfBuilding