PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.97k stars 2.08k forks source link

Incorrect effect of turbulent cata #5614

Closed JustTimeToSuffer closed 1 year ago

JustTimeToSuffer commented 1 year ago

Check version

Check for duplicates

Check for support

What is the value from the calculation ingame?

image image

What is the value from the calculation in Path of Building?

image image

How to reproduce the issue

When i checked in PoB, turbulent catalist scaled 4 stats on The Taming ring instead of 2 (all mods except resistans mods) The last stats

12% Chance to Freeze, Shock and Ignite 24% increased Damage with Hits and Ailment per Freeze, Shock and Ignite on Enemy is scaled, but in-game isn't And it's havent Damage+Elemental tag, only Damage or Elemental (here is second issue at all, extra tag elemental on "increased damage for ailment" mod, i think) Not checked at another jewelery, but maybe in Turbulent cata code missed second tag (Damage)

Cheched on Valaco Sign ring, and there the same - turbulent cata scaled the shock chance mod, which hasnt tag "Damage"

  1. Open Items tab in PoB
  2. Open The Taming Prismatic Ring in PoB
  3. Select in Catalist -> Turbulent ... Profit (u get scaled all mods except resistanses, but in game - not)

or

  1. Open Items tab in PoB
  2. Open Valaco Sign Topaz Ring in PoB
  3. Select in Catalist -> Turbulent ... Profit (u get scaled chance to shock mod, but in game - not)

Character build code

https://pastebin.com/AJ3QPdQb

Screenshots

image image image image

JustTimeToSuffer commented 1 year ago

Its actual only for checking in pob and theorycrafting, if u import build from the game - its importing correctly

QuickStick123 commented 1 year ago

Should be fixed in https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4467