PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
4.02k stars 2.08k forks source link

error with trade for these items #5621

Open i3luefire opened 1 year ago

i3luefire commented 1 year ago

Check version

Check for duplicates

Screenshots of crash/graphical issue, version and options menu

Trying to do the trade for these items feature. the first error is at the bottom when i first open the trade for these items window. it says "Error while fetching league list: JSON object not found on the page." in the screenshot attached i have hit the button "Get Currency Conversion Rates". i have tried restarting and re-installing the path of building application but neither have fixed the issue. image

What are your system specifications and configuration?

system_stats.txt hope that is enough info without being too much. short summary below. windows 10 education 21h2 32GB ram 3600mhz nvme primary os drive evga 3080ti R9 5900X

How to reproduce the issue

Open path of building community. load a build. go to the items page. click trade for these items. the first minor error shows up. "error fetching league list...... JSON object not found..." click get currency rates get the first screenshot error about classes/tradequery.lua:154 etc. if you don't click the get currency rates and instead click find best get the second screenshot error about classes/tradqueryrequests.lua:443

get currency exchange rates error. image

find best error. image

Character build code

No response

i3luefire commented 1 year ago

Is there anything I can do to help out with this? Do I need to provide any additional information?

Dullson commented 1 year ago

Can you update your POESESSID and try again to see if the problem persists? I suspect an invalid/expired POESESSID is the cause of this. We don't validate session keys at the moment and assume that the user has provided a valid POESESSID key.

QuickStick123 commented 1 year ago

Can confirm this is the problem. I remember testing this in a previous version and it was returning the correct error message. That might have just been because leagues weren't fetched using POSESSID, we didn't support no POESESSID and we only returned that as a generic error message. image

i3luefire commented 1 year ago

I will check that out asap and get back to you

On Wed, Feb 1, 2023, 18:10 QuickStick @.***> wrote:

Can confirm this is the problem. I remember testing this in a previous version and it was returning the correct error message. That might have just been because leagues were hard programmed, we didn't support no POESESSID and we only returned that as a generic error message. [image: image] https://user-images.githubusercontent.com/31533893/216197493-ef26136e-ec06-4541-94af-abe5cc37e657.png

— Reply to this email directly, view it on GitHub https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/5621#issuecomment-1412935576, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA25EQPT565XUISU42ELPS3WVL3OLANCNFSM6AAAAAAUDIMJME . You are receiving this because you authored the thread.Message ID: @.***>

i3luefire commented 1 year ago

Yep. That was the problem. I had been using the feature for a while and everything was working. So IDK how it got corrupted or whatever happened. Maybe they just expire after so many days or something.

Thanks for the help. And keep up the great work!

i3luefire commented 1 year ago

Sorry for closing this. I guess you probably want it open to update the error handling of Path of Building.

Namloc85 commented 3 months ago

I wasn't getting this error until yesterday. i updated my POESESSID and reinstalled pob but still getting the error

image image