Sort gems by DPS: Full DPS should include own DPS for active skills

[AnnanFay]

Check version

• [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• [X] I've checked for duplicate issues by using the search function of the issue tracker

How is Path of Building expected to behave?

DPS Sorting should be consistent with hover text.

I'm trying to look for highest dps skill given a fixed build, or fixed support gems - as auxiliary skill during level for ballista build. When I sort gems by Full DPS and include the current socket group in Full DPS it gives strange results.

Eventually figured out that it looks like the sorting is not taking into account the effect of adding the gem, but the hover over is taking into account. Only applies to the own dps of active skills when adding active skills to Full DPS socket groups.

How does Path of Building behave?

Initially I thought it was putting debuff skills at the top, but honestly not sure how sorting works in this case. But it clearly knows what effect on build would be of adding ability.

This shows the list isn't sorted by 'Full DPS'.

(note: if you search for gems it will auto-add them to build and hover will show no change since gem 'is already added' - not really important but a bit annoying)

How to reproduce the issue

1. Set socket group to be part of Full DPS. Supports don't matter.
2. Switch gem sorting by Full DPS
3. Sorting is wildly wrong, but hover is correct

Character build code

No response

Screenshots

No response

[Wires77]

Can you provide the build you're testing with?

[AnnanFay]

Can you provide the build you're testing with?

Build is a bit of a mess. I'll try to put together a minimal example.

Okay, here we are. Crude bow, no passives, config adds attributes to avoi requirement issues.

eNqtW1tz4rgSft78ChevpxIwtyRTZLe45EJVmHAgM3PO05SwBWhHllhLTsL8-m1JNjgEOTb2TNWMsfrrm7pbatnu_fUWUOcFh4JwdlNzLxo1BzOP-4Stbmrfnu_Or2p__XnWmyK5floOIkLVyJ9nf_T0tUPxC6aAawBOonCF5feEV-sn3NsgJteYswn6m4f33L-pfeUM15wFYj6RyS-PIiG-ogDf1OYegGsOEh5m_nB_3xAGiLA5935heR_yaHNTa9acF4JfJ9wHmvFk-jR7TgklLC0UtP6jN6Voi8O5RNIR8M9NrQ_GoxUeoQD-BW6IRsCqcXHpdprddq2eiRpEoZAFofMNxv6O2r2wEk5DfLtcYk-SFzwMiRyuEfP2cjo23BHa1kUzi3oSUUk2lOAwpZeV_8MH9nZjn7lEdDSdp_g2Gm6re93NRnC596eN8geR6wEFZxbir1DjFSMSF4ZNORGcnWRNGmQ1aBhRCtmVj5YHC8IK2j5BDA25yOFbRTnFISShLASYY49D3haVURD5SJY4P2UhO2JAUW1Os-N2npeuMOPTFJpBIctHOZf7WtFqWslG-C0P2Qz_k6Z0O9biM2Yyn9wXLvVK8pkhOkNvH6Z74a3rK2tJXm8F8RCdoDcSRAFUwmf0C7Nc2EeyWksG-W0DX11ay-gdCfEJsCGn_imwNeLiBJxKhFyugCXQ-6Kox8zLl1_fWIgFDl_SK2emr5d4BnGvVukFxbkxezFx_uyRjUa2sBVmscRtPpMeMfbW97ChmSGJ81XLHdXldTvTt4o4l28V4RHfZvB_jyjgJgU87ia3dXGdhSroqVuGw9V2viaY-sWoE82GaJOjAipHp9G5HP5eXKGgSUMLuuQHCv181b-oTi9IpMtss5PtLkOeLzQx7O0A4OOD3WbDvmHmf6vtMi0G64cBj8KcE26IcxmQLBamP5hhP_LyLUkDCi1OXu1BK0oLIfpSIu_XiPsrXEhIccQ82mygUqgpz4tTK90MC5Lag5x3c1A_QbzmSlu1JuYXsKfOLWC3zueXcgDJb4taqAsYsyfPLWLXgU6gIgRQ6nX7Cv32vnpbJwfamVy9jCbM2SNN-StovlZHDaIYNWxo9jtHqyohZr-3ufm_I88l4Jb5UahSIbeMQ0QuMX09Z7C3xcEjCYj8MFvPJID6KsQISeT48W75OwoJYrKpyByBUeitHyFY7hClCygZN7X0XfXrAOgm_Ht1fTykrsbBhodS3xwi6gktfcw2kXSYPtkJiPB-LqLlUh3igAAZ6rOn27u72-Hz-PttrHAaIn4RSn-yKFioEwvz_960OdZ11hHRQpjLm9p3gl_nCjXCEhEKbvc4pWgjsH9TWyIqQDKBS00zB894MoObpoKdcXLyc5zXnsDO6fYNhxLshQXaCwm26rUb_0QpI1At3mqCbdzU8YqdkVkfhkhIs7mweEofY9m5qHMlqzlqMAMLMYOoVXI8-okn5HaDBazYZEk8lRjZU_4M1IYqwy-eB4nobTPmO17l7Dz0eZWNgRm0g835kw0dj2Z4VZ96Wb1qRu3wEfaQ1XYzaAfv9qucPahqdJzLjiqD01fOdJBD0vQJVSuSdWZvKd6R2Bk-yTUOzTJn5TSBGpWQZCZOSBaRtKdxiiLDV7qNtnhIjdmhpkm02KDGMirRu67J4tA0jZ2V6TashSwLOsuop7PsUpps4y2eN6MZ9iedjMX0eDhDdb2xsk59vE3LKg2wh7eXBjVoB5vU-shChlFODjoNRniJoYBl5sGOJqMAy4iNoFbKDIfmZGUWtP4LJ75pIEpx00YeZ7b3VCFepr4c9VthjrrBKuv6g76rEvfHJ4CW0p8i-YQR1OyHjF1BPk67juQBI6oeynBajuGHk85SdnIpEPNH6hilpKHqFCbaALNEs6dj27p9lB1y7dWTDXdP73GEI2Anfo8DMdhCr3WnqniqS0PaqfEGWJoWIE2fiPLxEkVU3f9vhCiRW9W7pO4-mkfCHnQrwBKH-jfwWvNXFZeGpdpvCVjMn2aT_qMZ7FMZM1QiE38Z78RKaTNdfS--qZ8I9_eaa4u17oR5NPLxmMUG7iaAooXSTz3nVmfDOxcecNoJ-qMH-sTE95QvEG0mkPjpd7NRezfuJuO6Txnr1UfCFQ63A2ilYBmARfofY-tYb56072rOCgfq9wR6FB_6svoY2jdRV-6oa53gys5JT8OBTRBAzEylapzUAVZKF2fHom48aoSc6N3YI_mdawK_nsytDlgTp-ryOcQ4CUmtthuHAvxIvx2g_NVQ_AWE2jbeoykFGHSTcNG5umq1ao4Edqk3E9SMeXu4Mfnb7NFM-FrKjfhSr7--vl5skFzzJX4jFF94PKhvAAQ6neupPVds6334M1j19R_jx4RTz7yrIBJTQXdtpjJOXXyF_lw3xOpm8kObrvrVuNeey1DZ85vz4P83tfPWtXvRcVtXzbZJG6iCcoI2u_BWdHEKXsdZB33NiIBnQl3tkylRhP8Dhh23eeFedy9b5rFxTwdd7Hp1nRSDSGDzKPEHRhvO9O1UjirSdH7OEPR42y-OSfGzYQjh4gz461mc5F-cZuMs9s8X5_589_cM-jtKPKJuN7TfFOudDFUG7Kq8rxCUQ8kAzHQBM6KDQh8fQJa-qLVaDZkAqGcDjBjH3UPczyADDguB019shUDUMXY6nQIyB5jKQ3yzAP4OwvuX0zrBSmf-ijaHotunMCphfsyjWQGP4wZ1KzCoW4FBJ_E4ZpBbJLiORWerAo80q7KmSLw9YNiEy1L-OJJs3dIaNAtzKC2yVZX_OxUEg1tBergV6NEuGAlVlZhm2YxsV-DA4mtGZSW2Vdb-ZskULqaAv3XMKVGZGDR7izIcjid2pzSHblXT6lZVY4qHZnk_tkvPZaeaoCpifD-IKJYVVMJWBQWlVTIp2yXxbjX-P3mlLBy07cKIU3ZRJb3aKVurK5qWdlXFpbJ99cktVAHcjLBVoSk8Xpqa1cxBZStFFQ1f-zSbijq__Bpf0WajU1qR8ktct2gxKFs8Pgo0pz7JuaA-k9KvkHC2JKsPL4Qcfma0f41Ef_nz8Q0SzHCwnZPfeKreZJV7-gn2SRQcQRx-VJRPxFgMuBCf0nqRkDyYcD9F-p9Wo-HMZYjZSq7P9K8xk5hSslLneObOCL9JrA7ajjA131gdlT2lyMNrTn0cvnOI-TQpeaHmMv0y7zH6-M1GTukMMfXoao_MBiY5unt157LZvcqGpL9qSmCdzyHJKzoJpPWJZrvHwAngqnX1iWbv3_NMGdWM36Lu1ZOw7dUPP6T7FwC5qUg=

[AnnanFay]

It seems to really love ensnaring arrow. I thought maybe I could filter out all the spells and melee attacks to more easily understand what is going on, so added a bow damage increase. Ensnaring arrow went to top, but Arc was still second, none of the other bow abilities made the top list.