Phantasmal Cremation Corpse Explosion DPS

po0p commented 1 year ago

Check version

[X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

[X] I've checked for duplicate issues by using the search function of the issue tracker

Check for support

[X] I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the value from the calculation ingame?

Phantasmal cremation corpse explosion DPS should be calculated as following: Damage of 1 corpse explosion (I assume it is "average hit" in POB) x Number of projectiles overlapping on target (That is impossible to calculate correctly so I use "Count" option in pob). So final calc is: DPS = "Average Hit" x "Number of overlapping proj" (=Count)

Calculation should be like this, because, as per gem text, cremation fires projectiles once a second, and AFAIK that value is not modifiable my any mods/support gems/etc, so cast speed should NOT scale corpse explosion damage/dps at all.

What is the value from the calculation in Path of Building?

In Path of Building using phantasmal cremation the DPS of corpse explosion part is scaled by cast speed - easy to verify by adding/removing cast speed in custom config, or adding removing cast speed with weapons/etc. Also, while using "Find best" weapon cast speed has a pretty heavy weight I think.

How to reproduce the issue

Select phantasmal cremation
Add/remove any amount of cast speed
DPS changes while it should not.

Character build code

https://pastebin.com/U7jwBm0Q

Screenshots

No response

po0p commented 1 year ago

Probably should also multiply the calculation for true dps by chance to explode the corpse normalized to 1, i.e. with 98% chance to explode it would be average hit x 0.98 x count of projectiles overlap

QuickStick123 commented 1 year ago

Phantasm cremation isn't supported. It is simply assuming you are casting repeatedly blowing up corpses with the initial explosion. Red Text = Feature Request

Regisle commented 1 year ago

Phantasm cremation isn't supported. It is simply assuming you are casting repeatedly blowing up corpses with the initial explosion.

tbf its super easy to fake with custom mods atm, divide by cast speed (to get cast time of 1), multiply dps by num projectiles/second (to get num explosions per second)

but yeah as quick said should be a feature request not a "bug calc"

also the base skill itself has calc issues as well, it also doesnt use num projectiles etc, I would advise anyone trying to fix this to first fix the base skill, and use that fix to apply to a new skill part (or config to turn second skill part into) for phantasmal

po0p commented 1 year ago

Phantasm cremation isn't supported.

Sorry, maybe I indeed misunderstood something and created under wrong tag. My point is since its possible to select "Corpse Explosion" part for dps calculation let us at least calculate that dps properly! Corpses are exploding when firing projectiles, and as per gem text projectiles are fired strictly once per second, and that value is not scalable, so the 'Hit DPS' part should not be scaled by cast speed by any means.

deathbeam commented 1 year ago

Cremation explodes corpses when creating the geyser as baseline so technically the current corpse explosion calculation is accurate. And scales from cast speed. And that is what the "Corpse Explosion" dropdown is showing.

po0p commented 1 year ago

And scales from cast speed.

How does it scale from cast speed exactly? From wiki:

Cast speed: Only affects the speed to create a geyser. Fire frequency is not changed.

The Projectiles are fired per second, so increasing the Duration of the skill increases the total number of Projectiles. (If you make Cremation have a Duration of 12 seconds, you will get a total of 48 Projectiles.)

For sure, if you use "Spell" part of damage it should scale from cast speed, as the damage happens faster the faster you create the geysers. But the corpse explosion part happens when the geyser is already created, and fires projectiles. Imo it should not be scaled with cast speed, as corpse explosion (together with firing projectiles) happens at fixed intervals.

deathbeam commented 1 year ago

The corpse explosion happens when you create geyser. That is default behaviour of Cremation. Phantasmal Cremation is unsupported and so there is no way to check dps when exploding corpses when firing projectiles, as that is behaviour solely limited to Phantasmal Cremation but its also not what Corpse Explosion part of Cremation is trying to show.

po0p commented 1 year ago

Oh, right, i see now. Never actually checked the "normal" cremation gem text. Well, then it turns into a request for supporting phantasmal quality.

Nightblade commented 1 month ago

Should this be closed as "not planned"?

PathOfBuildingCommunity / PathOfBuilding