Managing Passive Trees Quality of Life

capSAR273 commented 1 year ago

Check for duplicates

[X] I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Most of the time builds use the latest version of the passive tree, but in the cases where they do not, some quality of life improvements to the Manage Trees popup would be helpful:

Allow multiple trees to be selected to be deleted at once
Mass-update all trees with one button to the latest version
Auto-resize the list of passive trees to match the tree names (currently is a set size, unable to be resized)

Describe the solution you'd like

In TreeTab.lua, update the function OpenSpecManagePopup to resize the window based on the longest tree name in the list. Would need to pass the list of passive tree names over to this function and calculate the max length from that.

Add functionality in PassiveSpecListControl.lua to select multiple trees to copy/delete at once (for those builds that have multiple trees for stages of levelling/budget/etc). The mass-update functionality would probably also be added here.

I have some basic Lua knowledge, so I will try to work on this myself, but if I missed a file that would need changes or if these suggestions were already considered and not wanted, please let me know.

Describe alternatives you've considered

No response

Additional context

Example image for current tree window:

Wires77 commented 1 year ago

There was a significant amount of work done in this PR, and it was 95% done before the author closed it. If you want to pick that code up and take it across the finish line that'd be great! https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4104

capSAR273 commented 1 year ago

Wow, you're right. I'll take a look at this, thank you.

PathOfBuildingCommunity / PathOfBuilding