PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.99k stars 2.08k forks source link

Prismatic Burst not calculating spell damage correctly #5994

Closed JoeMurrayH closed 1 year ago

JoeMurrayH commented 1 year ago

Check version

Check for duplicates

Check for support

What is the value from the calculation in-game?

in-game i have tested this by refunding light of divinity and my prismatic burst damage has gone down, but there is no such effect in pob

What is the value from the calculation in Path of Building?

in path of building, i have light of divinity allocated and it is not appearing in the prismatic burst calculation. It appears that no spell damage boost or spell crit chance is being applied in pob to prismatic burst, I also have battlemage which is not being added to prismatic burst, unlike other spell skills.

How to reproduce the issue

start a templar select any attack skill and add in a prismatic burst as a support gem. and path to light of divinity

Character build code

https://pobb.in/he3_6Sibr9ef

Screenshots

image

QuickStick123 commented 1 year ago

It hasn't really been implemented yet but will be in https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5969. Which I assume probably fixes this issue? I don't really now how it is meant to work as haven't looked at the gem.

Paliak commented 1 year ago

https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5969 only adds basic support for it and does not consider it a self trigger. It's implemented in #4599 based on my current understanding of the gem.