Plume of Pursuit applying 80% less damage even when hit is a crit

PAK90 commented 1 year ago

Check version

[X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

[X] I've checked for duplicate issues by using the search function of the issue tracker

Check for support

[X] I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the behaviour in-game?

Plume of Pursuit shouldn't add its 80% less damage modifier if the hit is a crit

What is the behaviour in Path of Building?

Even though the hit is a crit, because I've set 'Repeat Mode' to be 'Final' (and it shows 100% crit chance in the sidebar and in Calcs), it still includes the -80 mod in the 'Total More' calculation for All Types.

I've tried adding '80% more damage' in config custom modifiers to cancel it out, but apparently the math doesn't work that way; what should I put in the custom modifiers to cancel this out until a fix is done?

How to reproduce the issue

Add Plume of Pursuit
Add any skill, then support it with Spell Echo
Change Repeat Mode to Final in configuration
See in Calcs that it's still applying -80 to the More multiplier

Character build code

eNqtW1lv4zgSfm7_CsHAALsP8SEf7Q6cGTjOCeTw2En37lODlmibE4p0S1QSz2D_-xZJSZYdU5EsOUAii_UVq4pkXVKGf7x71HrFfkA4O6u3G626hZnDXcKWZ_Xnp6uTQf2P32vDCRKrx8V5SKgc-b32ZaiuLYpfMQVc3RLIX2LxPebU-Qmc1oiJFebsHv3F_WvuntUfOMN1a46YS0T8zaEoCB6Qh8_qMwfAdQsFDmbueHs_IlwhHzkC-3dy1lEo-D13YVT4IYx6iLAZd16wuPZ5uFZCvRL8pmlu7yeP06eUSISlRQKNvgwnFG2wPxNIWAH8OquPwDBoiW-IAFaIhsCn0-12681M8vPQD8QF8uAygfUHg4EJNltj7CaU7Uav208-X02giY8vFwvsCPKKxz4R4xVizna-dqtlQhanvg-pIGtKsJ-W0oS4KcL-iQtELyazhNbu9zuNTj-bnm_Xw8j5BxGrcwqWLcD9dsmIwGlAp2f3G-1vg_5Xu9351sma7CO43x58a_R6ecATTgLOjjDEEcKOQ0rhEKeRRitOcYD9VyTIrnDm7cK9OWG7Rs9phpGP0eNCb-opckkYJBy-mTD3iKExD1LH82sW6QT74FjEDqL1CWCGHQ6-KA2xB41-u5N8csx4mI9x6juywPkpC2kVAYpKc5wel7O8dIUZHyfQFHxyPsoZD2lOSrF1i7aR6gK_56C6ZSIH1RT_ShO2ez3zrK9cqJD6mRbKn1zeTLZcu3Zj0PsKf9RvYxxabQLiIHqP3okXeuD8n9ALZik2PfO-Wq4EA09kwn5rm6BXxMfFUWNO3SNQK8QDE6wzyDo1WxfYygj-zqmkvWVOvqP4zHzllFM5Qz8TMIUDIjOTOcU5EdspomOWJ5TrqZaYRfNt8qlzh7GzuobcbYoEzueVE6petlklbS6zSsIDZu3lBBQwkgQajNTIjHIFzXTJsL_czFYE060-g14e8liyMVrnQCpDp-G5DL47X6E9k4YWNMoP5Lv5YkRRmV5RkPay7X62uTR5vq2JIYcFgIv3kuqWuTLgf8m6gBaDjXyPh36OcCc10MS5FIgDhC6IptgNnXwR6ZxCMZdXepCK0kKIkRDIebng7hIXmqQ4Yhau1-Aq5JLnxcn4Bqk3SeUfJ_0c1I-wX9PntpUVCvNPsKXOPUES3PPPsgfJr4sM0AWU2ZLnniIpte_BI3jg61XNfs9TZbtxcaDaylU6KcLdgs58qPgbSL6SLZegGDUkMtvkxSiKj9nfm9z8d8hzTXDJ3NCXRyH3HPuIQ9M8EQ-8ZRBcIIEsN0p9vyOfICZs1Q8KMPKd1R0s_RWidA4O4Kyeviu_7QHb8doOm6rlJa9uvTX3hYXf5Z8J8sXmrL5ANMCaUN0BPoEgTJXO4G0orVuzFX8bua9SiyfOaRCDLLReY-bu8HjyMbaQ2nPS40ohlI7yS7o_dutKo1keCgSEKr1PA6kG4yAA5DCDAVSolgB2qd6c3Y7abhouOX8ZPk_v1MWXlRDr4LTZfHt7a6yRWPEFfodw0nC411wDCGQ6CV4IpSeSbXMEn_PlSH0Uo2bMaaj7cYFenqaUXRlSKicvHrjAgRyTN-Mvw5lkHVgB2PYae8H5Bo7ElQz3e-2FyDqSeoaFXt80Jm4MuniBQirv_xkiSuRitdJ373QPk3HfS-oYYAWLJT235vi0WUtrju7u9MiIioiZnC5eOb1CkUAWceNVi26qFuVoK_UYUSdQchPm0NCFGiDyFiANgQ1D0VxKJluyMnt3063OFJ9kmi9DkCYivqZ8jqgdQ6JGrd2q74y343G1nnI3yGACAzD7L62gvHmhjRWRyf2txF5iT47eY4FcOHPNWwHGaEqLNJVgcPWBnTL-nj4J161FHB4yPQlDXnQEEl7NyrSNVlh1OB0kA0hKa1hk7MMJxna2qsku-cgmLUOi7iHdVKZgXTorHmk31CaMTk60p9Tp0edDXipzKYpbtg6FYndW90jg_JyHi4XsfIOuwlfN_Murq8vx0-33y8hbpiHKHj9Z6M1lj1f_3ca0GVYpmxWE80BfntW_E_ymBLkAixAaSK0oResAJ35MHYBIcgq4DG6KCorruGt-mNeWwMzp8h374HaXkOs7PsFGuZLxT4TSE8o6QEYXEzfZkTYz0qnmGPaFrlMMllKPAcxcZCfeqI4czMBCwELUOHM0-oklhHSBsFfJgjgyMGcvuXSYmirDLo4DMd3ZZKx3lDCbeagWv4mBHjSDddfdhI5GM6yqOv5Gq-pRM_wCO8ioux40g5PSlzP1eOowl4Qqg9MDZ2qTw6EZESqTW-PKXlKckJgZPooV9qNMxMTpHnxUTJJ5cHwyD4X5GKcoMmylWnEGC8kxM1S3mww6yLEMT7TTgjEYNE1jZqUbF0ZHlgXVhY7RflHZlLEEUVvAYH49mmGEuDNi0D8azjgkyv-OXjlxdelsOC57ZFkOA3LS8mxUG6A8m_0GQXmOV5DWvxjXOxo1w58FkXnLAS46d8nFRB6qchzk2SrHYbqfSGyx0-wUQvkvyHgxGDrTgSU0GesrQnYBQU5krG1OVkqswwdhq1ohXtqVH9S0MEe9QaOHI1l7WJN8wghi0U1GtpOPU9K0ucGIykfsnJZj-OEhUCk9uQgQcy9kp7mkorJRHa6BWSzZ46F0dbuk-1yHzbiQUG0HmdpHPZGZ8GX5-Tfn3n9V4Savonq5E9XIkORdEDC1r7ZIPI8k_E_czxmqaikq2OV1XK-HAdaPb39gtOZM3ZaVry5QgDBdRE8RJLmbU-v54fbP58vahIYetvjCmoR-EBJRO-cMW2PiOxSLmo6slg6tp9bArqVj7TkK4kfahOJTq9Vow6d2h9EyhK83yH_FgahFJf6pZbdqUSvj1Do_UT81ZYYp_nVq9bs1SKEpcYgcb9X-8RFb4tNWo_e_f3VaJ3br379Zvmx8Y9eSVYClUv0dskHrpN2RdIQ5PgbpXGtHgxpkaSdQsMjykqqS7gUHlgsb2xq0frNk18vSy1rTlWTUREH0DW0iwnEMn0Vw2EYLwuDGFK8xErtIBzHGhQGJ3x28Fh8YyLIVis6p1MtS2snnWr16tIpRYWuksD-l6HxK0f2UIn6UpUr4ZKPJho1pN-52cihYBRJ7bzJ_nt6pTpsqoa8pFIlwkOWQ7qo1swF6EqtdAHLOwWlYo_kmCORiqB1p9YowwFTs4-0CeBV1rc4RWlqzN7Ten7p7DKMS6kc87Ap4HFaoX4FC_QoUOorHIYVK785OBRaxq9KmyH67wZAdiVL2OHDY-qUlsAtz2ALax03Zqcr-vQo2Q7uC49GuQI5uwZ1QlYuxy57IbgUGLB4zKnOxnbL62yWPcDEB3I2lmyRl9qDOLcpwOHywe6U59Kta1nZVPqb41ixvx27ptexVs6mKKD_yQopFBZ6wU4FD6ZQ8lN2S-HY19j86UhbetN3CiGOyqJJW7ZX11RUtS7cq51JZXn10CVUANyVsWWgJD7smu5o1qCxSVFHwdY_Tqajxy8f4ipKNXmlByoe4flFnUNZ5fJxQ93zi9yhUU1K9RsHZgiw_vBThq6bW7ksUV7cPo7vtO2oOXnHqYj9CYIa9TfTvfPFLFF_TL4MfopfNtfi9hxjU-QQTb8eY3rY_nyN-9zTG9LIhu-_tpvTJhiUP_GL6_ieA6L1gTqlq16UNFzeno-UZNvf_C_X_2rGzpA==

Screenshots

QuickStick123 commented 1 year ago

This seems to just be a visual issue as it is showing the non-crit parse but with the final repeat.

PAK90 commented 1 year ago

It's also applying to my damage multiplier though? I shouldn't be seeing x0.224, I should be seeing 1.6*0.7=1.12 multiplier from the divergent spell echo (30% less, 60% more).

QuickStick123 commented 1 year ago

Crit Damage / Non crit = 7.5

1.5 / 0.2 = 7.5 so it is behaving as expected.

That breakdown is only for the first parse (non-crit) so it produces issues another case of this is winds of fate https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/5470.

PAK90 commented 1 year ago

Crit Damage / Non crit = 7.5

1.5 / 0.2 = 7.5 so it is behaving as expected.

That breakdown is only for the first parse (non-crit) so it produces issues another case of this is winds of fate #5470.

Ohh I see... that makes sense now, thanks for explaining it. Bit of a bummer since I'd applied '80% more damage' in my build pob to counteract that -80 and now it's got way less damage... oh well.

PathOfBuildingCommunity / PathOfBuilding