PathOfBuildingCommunity / PathOfBuilding

Offline build planner for Path of Exile.
https://pathofbuilding.community
Other
3.95k stars 2.07k forks source link

Effective HP pool bugged #6871

Open Ilsyer opened 9 months ago

Ilsyer commented 9 months ago

Check version

Check for duplicates

Check for support

What is the value from the calculation in-game?

I used to have a value of around 64k effective HP on my build, but after i went into the config and checked uber shaper slam with 100 %roll and 100% crit then back to no boss selected and back to guardian/pinnacle boss toggled my Effective HP pool was 451k which is obviously not true image Sadly don't have a ss from before the change happened, but have been able to reproduce the bug (esp if you repeat aforementioned steps, the number will keep increasing)

After writing this entire report and testing it, i cant seem to replicate it on the given file, so i'll attach a second build to showcase it

What is the value from the calculation in Path of Building?

I believe the Effective HP pool isn't properly "cleared" off stats when you change, and thus adding on top of itself each time you "swap" between steps, the actual formula I do not know

How to reproduce the issue

Go into config Set enemy stats from guardian pinnacle to Ubers set skill preset to for example shaper slam change the skill range % from 70 to 100 change crit chance from 0 to 100 set skill preset back to none set boss back to guardian and keep swapping for number increase change to multiply

Character build code

this happens in any build, but its currently broken in this one

https://pobb.in/qPPnuN7Q-V_F

Screenshots

https://github.com/PathOfBuildingCommunity/PathOfBuilding/assets/42869616/98939bdc-5f68-482a-8f8b-58194948cf43

https://github.com/PathOfBuildingCommunity/PathOfBuilding/assets/42869616/905d8c29-d3a9-4e65-91e0-fce9d34ea64b

Regisle commented 9 months ago

The enemy damage type doesnt change back when you change boss skills so the first video atleast is just the difference in tanky-ness of vs melee instead of projectile spell The second video goes from average to melee

It shouldnt save the damage type like this, but theres as many config issues changing it back to "none" when you change back, so the best solution is to just manually change the damage type back to "average" (or whatever config you want) after you change the boss skill

Ilsyer commented 9 months ago

Would it be possible to have a "reset to default" button that does that for us? cus i think a lot of people wouldn't know "whats the normal"