Paliak
commented
8 months ago This is because it's using Vaal Cyclone and not the Cyclone part as trigger source.
Vaal cyclone is not being disabled by the switch due to this line:
diff --git a/src/Modules/CalcSetup.lua b/src/Modules/CalcSetup.lua
index bc632636..2e347fcb 100644
--- a/src/Modules/CalcSetup.lua
+++ b/src/Modules/CalcSetup.lua
@@ -1397,7 +1397,7 @@ function calcs.initEnv(build, mode, override, specEnv)
if gemInstance.enabled and (gemInstance.gemData or gemInstance.grantedEffect) then
local grantedEffectList = gemInstance.gemData and gemInstance.gemData.grantedEffectList or { gemInstance.grantedEffect }
for index, grantedEffect in ipairs(grantedEffectList) do
- if not grantedEffect.support and not grantedEffect.unsupported and (not grantedEffect.hasGlobalEffect or gemInstance["enableGlobal"..index]) then
+ if not grantedEffect.support and not grantedEffect.unsupported and gemInstance["enableGlobal"..index] then
local activeEffect = {
grantedEffect = grantedEffect,
level = gemInstance.level,I'm not really sure why global effect check is there. Removing it fixes the issue as it correctly disabled Vaal Cyclone.
TechHypno
Check version
Check for duplicates
Check for support
What is the value from the calculation in-game?
trigger rate not available in game
What is the value from the calculation in Path of Building?
Socket group: Vaal Cyclone - Cast On Crit - Ice Nova - Inspiration - Added Cold Damage - Increased Critical Strikes
With 100% crit chance, 5% hit chance and thus 5% effective crit chance, PoB calculates the ice nova "Skill Trigger Rate" and "Eff. Source Rate" to be 6.03, while the "Trigger Rate Cap" is 6.06 with no CDR.
How to reproduce the issue
New build New socket group: vaal cyclone, cast on crit, ice nova In Vaal Cyclone options uncheck "Enable Vaal Cyclone", make sure "Enable Cyclone" is checked. Check "Include in Full DPS" New item (Weapon 1): Cospri's Malice Go to Configuration Add the following custom modifiers: -10000 accuracy 10000% increased melee critical strike chance Go to Calcs Select Active Skill: Ice Nova Read Skill Trigger Rate: it is 5.34, but should be nearly zero. Eff. Source Rate reports 100% hit chance from vaal cyclone With the average hit 1323.5 Full DPS reports 7067.4 but should be like less than 500. I have provided a build code for this simpler setup instead of the one I described in previous steps.
Character build code
Screenshots
No response